Google Git
Sign in
android/platform/frameworks/support/48c135285b0061ff6527b6ac547aec92a83a2949
commit
48c135285b0061ff6527b6ac547aec92a83a2949
[log]
author
Ian Lake <ilake@google.com>
Tue Mar 14 18:27:02 2023 +0000
committer
Ian Lake <ilake@google.com>
Tue Mar 14 18:27:02 2023 +0000
tree
43a68fa4a1d5b2cd4b4c92fb725893cbbed64653
parent
bb98f15d301d8611bc408f688f10e50d554e8e68 [diff]
Fix re-entrant removal of result listeners in STARTED+

When a fragment result listener is added when the Lifecyle
is already at least STARTED, it is immediately sent the
result when the LifecycleObserver is added. This was
previously done before actually adding the new listener
to the map of result listeners, which meant that
re-entrant clearFragmentResultListener calls wouldn't
find the new listener to remove.

By moving the addObserver after actually adding the
new listener to the map, we ensure that this case works
as expected.

Relnote: "Fixed an issue where calling
`clearFragmentResultListener` inside a
`setFragmentResultListener` wouldn't work if the
`Lifecycle` was already `STARTED` and a result was
already available."
Test: new FragmentResultTest
BUG: 273454803

Change-Id: If7458be3c43ece5a7ee3b1fe5b89bef2cf8b6131
2 files changed
tree: 43a68fa4a1d5b2cd4b4c92fb725893cbbed64653
  1. .github/
  2. .idea/
  3. activity/
  4. ads/
  5. annotation/
  6. appactions/
  7. appcompat/
  8. appsearch/
  9. arch/
  10. asynclayoutinflater/
  11. autofill/
  12. benchmark/
  13. biometric/
  14. bluetooth/
  15. browser/
  16. buildSrc/
  17. buildSrc-tests/
  18. busytown/
  19. camera/
  20. car/
  21. cardview/
  22. collection/
  23. compose/
  24. concurrent/
  25. constraintlayout/
  26. contentpager/
  27. coordinatorlayout/
  28. core/
  29. credentials/
  30. cursoradapter/
  31. customview/
  32. datastore/
  33. development/
  34. docs/
  35. docs-kmp/
  36. docs-public/
  37. docs-tip-of-tree/
  38. documentfile/
  39. draganddrop/
  40. drawerlayout/
  41. dynamicanimation/
  42. emoji/
  43. emoji2/
  44. enterprise/
  45. exifinterface/
  46. external/
  47. fragment/
  48. frameworks/
  49. glance/
  50. gradle/
  51. graphics/
  52. gridlayout/
  53. health/
  54. heifwriter/
  55. hilt/
  56. input/
  57. inspection/
  58. interpolator/
  59. javascriptengine/
  60. leanback/
  61. lifecycle/
  62. lint-checks/
  63. loader/
  64. media/
  65. media2/
  66. mediarouter/
  67. metrics/
  68. navigation/
  69. paging/
  70. palette/
  71. percentlayout/
  72. placeholder/
  73. placeholder-tests/
  74. playground-common/
  75. preference/
  76. print/
  77. privacysandbox/
  78. profileinstaller/
  79. recommendation/
  80. recyclerview/
  81. remotecallback/
  82. resourceinspection/
  83. room/
  84. samples/
  85. savedstate/
  86. security/
  87. sharetarget/
  88. slice/
  89. slidingpanelayout/
  90. sqlite/
  91. stableaidl/
  92. startup/
  93. swiperefreshlayout/
  94. test/
  95. testutils/
  96. text/
  97. tracing/
  98. transition/
  99. tv/
  100. tvprovider/
  101. vectordrawable/
  102. versionedparcelable/
  103. viewpager/
  104. viewpager2/
  105. wear/
  106. webkit/
  107. window/
  108. work/
  109. .gitignore
  110. .mailmap
  111. build.gradle
  112. cleanBuild.sh
  113. code-review.md
  114. CONTRIBUTING.md
  115. gradle.properties
  116. gradlew
  117. libraryversions.toml
  118. LICENSE.txt
  119. OWNERS
  120. PREUPLOAD.cfg
  121. README.md
  122. settings.gradle
  123. studiow
  124. TEXT_OWNERS
README.md

Android Jetpack

Revved up by Gradle Enterprise

Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.

Jetpack comprises the androidx.* package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.

Our official AARs and JARs binaries are distributed through Google Maven.

You can learn more about using it from Android Jetpack landing page.

Contribution Guide

For contributions via GitHub, see the GitHub Contribution Guide.

Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:

Code Review Etiquette

When contributing to Jetpack, follow the code review etiquette.

Accepted Types of Contributions

  • Bug fixes - needs a corresponding bug report in the Android Issue Tracker
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests
  • New features to existing libraries if the feature request bug has been approved by an AndroidX team member.

We are not currently accepting new modules.

Checking Out the Code

Head over to the onboarding docs to learn more about getting set up and the development workflow!

Continuous integration

Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.

Password and Contributor Agreement before making a change

Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:

Generate a HTTPS password: https://android-review.googlesource.com/new-password

Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing or check the OWNERS file in the project's directory)

Handling binary dependencies

AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.