Changeset 61442

Timestamp:

01/06/2026 05:12:34 AM (3 months ago)

Author:

westonruter

Message:

Code Modernization: Script Loader: Use null coalescing operator instead of isset() ternaries.

Developed as a subset of ​https://github.com/WordPress/wordpress-develop/pull/10654
Initially developed in ​https://github.com/WordPress/wordpress-develop/pull/4886

Follow-up to [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403].

Props costdev, westonruter.
See #58874, #63430.

Location:

trunk/src/wp-includes

Files:

• class-wp-scripts.php (modified) (1 diff)
• class-wp-styles.php (modified) (2 diffs)
• global-styles-and-settings.php (modified) (1 diff)
• script-loader.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-scripts.php

@@ -451 +451 @@
 
         // Determine fetchpriority.
-        $original_fetchpriority = isset( $obj->extra['fetchpriority'] ) ? $obj->extra['fetchpriority'] : null;
+        $original_fetchpriority = $obj->extra['fetchpriority'] ?? null;
         if ( null === $original_fetchpriority || ! $this->is_valid_fetchpriority( $original_fetchpriority ) ) {
             $original_fetchpriority = 'auto';

trunk/src/wp-includes/class-wp-styles.php

@@ -204 +204 @@
 
         $rel   = isset( $obj->extra['alt'] ) && $obj->extra['alt'] ? 'alternate stylesheet' : 'stylesheet';
-        $title = isset( $obj->extra['title'] ) ? $obj->extra['title'] : '';
+        $title = $obj->extra['title'] ?? '';
 
         $tag = sprintf(
@@ -231 +231 @@
         if ( 'rtl' === $this->text_direction && isset( $obj->extra['rtl'] ) && $obj->extra['rtl'] ) {
             if ( is_bool( $obj->extra['rtl'] ) || 'replace' === $obj->extra['rtl'] ) {
-                $suffix   = isset( $obj->extra['suffix'] ) ? $obj->extra['suffix'] : '';
+                $suffix   = $obj->extra['suffix'] ?? '';
                 $rtl_href = str_replace( "{$suffix}.css", "-rtl{$suffix}.css", $this->_css_href( $src, $ver, "$handle-rtl" ) );
             } else {

trunk/src/wp-includes/global-styles-and-settings.php

@@ -284 +284 @@
         if ( $can_use_cached ) {
             // Use the block name as the key for cached CSS data. Otherwise, use a hash of the metadata.
-            $cache_node_key = isset( $metadata['name'] ) ? $metadata['name'] : md5( wp_json_encode( $metadata ) );
+            $cache_node_key = $metadata['name'] ?? md5( wp_json_encode( $metadata ) );
 
             if ( isset( $cached['blocks'][ $cache_node_key ] ) ) {

trunk/src/wp-includes/script-loader.php

@@ -1985 +1985 @@
     $user_id            = get_current_user_id();
     $saved_location     = get_user_option( 'community-events-location', $user_id );
-    $saved_ip_address   = isset( $saved_location['ip'] ) ? $saved_location['ip'] : false;
+    $saved_ip_address   = $saved_location['ip'] ?? false;
     $current_ip_address = WP_Community_Events::get_unsafe_client_ip();