Skip to content

Fix Safari tab bar having low contrast on docs website - #12001

Merged
orta merged 1 commit into
jestjs:mainfrom
dcastil:11984/fix-safari-tab-bar-low-contrast
Oct 29, 2021
Merged

Fix Safari tab bar having low contrast on docs website#12001
orta merged 1 commit into
jestjs:mainfrom
dcastil:11984/fix-safari-tab-bar-low-contrast

Conversation

@dcastil

@dcastil dcastil commented Oct 27, 2021

Copy link
Copy Markdown
Contributor

Closes #11984

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Hi @dcastil!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@dcastil dcastil changed the title Set theme-color of docs to white Fix Safari tab bar having low contrast on docs website Oct 27, 2021
@dcastil

dcastil commented Oct 27, 2021

Copy link
Copy Markdown
Contributor Author

Something is not working with the CLA. I'm getting a 500 error after submitting it.
Screenshot 2021-10-27 at 15 16 53

@SimenB

SimenB commented Oct 28, 2021

Copy link
Copy Markdown
Member

@JoelMarcey any idea what's up with the CLA?

@orta

orta commented Oct 28, 2021

Copy link
Copy Markdown
Member

👍🏻 if the CLA takes till the weekend, I'll reimplement it

@JoelMarcey

Copy link
Copy Markdown
Contributor

Can you try again? There was an issue with the CLA yesterday that I hope is now fixed.

@dcastil

dcastil commented Oct 29, 2021

Copy link
Copy Markdown
Contributor Author

It worked! 🙌

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@orta

orta commented Oct 29, 2021

Copy link
Copy Markdown
Member

Fail looks unrelated - thanks

@orta
orta merged commit 97e1eac into jestjs:main Oct 29, 2021
@dcastil
dcastil deleted the 11984/fix-safari-tab-bar-low-contrast branch November 22, 2021 18:35
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Content of Safari 15 tab bar hard to read on Jest docs website

5 participants