Skip to content

feat(jest-core): Pass project config to globalSetup/globalTeardown as 2nd argument - #12440

Merged
SimenB merged 1 commit into
jestjs:mainfrom
ahnpnl:feat/project-config-global-setup-teardown
Feb 21, 2022
Merged

feat(jest-core): Pass project config to globalSetup/globalTeardown as 2nd argument#12440
SimenB merged 1 commit into
jestjs:mainfrom
ahnpnl:feat/project-config-global-setup-teardown

Conversation

@ahnpnl

@ahnpnl ahnpnl commented Feb 20, 2022

Copy link
Copy Markdown
Contributor

Summary

Closes #12436

Test plan

Updated e2e tests

Green CI

@ahnpnl
ahnpnl force-pushed the feat/project-config-global-setup-teardown branch 2 times, most recently from f9eec12 to fc820f7 Compare February 20, 2022 12:38
@ahnpnl
ahnpnl marked this pull request as ready for review February 20, 2022 13:02
Comment thread docs/Configuration.md Outdated
Comment thread docs/Configuration.md Outdated
@ahnpnl
ahnpnl force-pushed the feat/project-config-global-setup-teardown branch 2 times, most recently from 110606b to cce4adf Compare February 21, 2022 20:37
@ahnpnl
ahnpnl force-pushed the feat/project-config-global-setup-teardown branch from cce4adf to 29f0422 Compare February 21, 2022 20:39
@ahnpnl
ahnpnl requested a review from SimenB February 21, 2022 21:47

@SimenB SimenB left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB
SimenB merged commit 5d883fb into jestjs:main Feb 21, 2022
@ahnpnl
ahnpnl deleted the feat/project-config-global-setup-teardown branch February 22, 2022 05:32
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Allow globalSetup to access things in globals

4 participants