fix(@jest/reporters): do not transform file paths into hyperlinks - #13399
Merged
Conversation
Member
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #8980
Summary
There was a plan to revert the above mentioned PR already (see #8980 (comment)) and there was a PR trying to do so #9294. The reasons are well explained there
I would like to add that VS Code was added to
supports-hyperlinkslist recently. Hence the issue will be visible for much more users now.This change could look breaking and I could agree with that. In the other hand, this is mostly aesthetic change. Just to be sure, I was trying out few terminal apps (e.g. iTerm). Only the underlines get removed, but
cmd/ctrl + clickworks as expected.Also note that current implementation lacks consistency. Paths in the stack trace are not underlined, as well as paths with RUNS:
(This screenshot still looks alright. In realty readability is worse.)
Test plan
Green CI.