Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: hashicorp/go-hclog
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.6.0
Choose a base ref
...
head repository: hashicorp/go-hclog
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.6.1
Choose a head ref
  • 4 commits
  • 2 files changed
  • 3 contributors

Commits on Dec 4, 2023

  1. Add test of colors with ForceColor 

    go test -v -run TestLogger/colorize
    @dolmen @evanphx
    dolmen authored and evanphx committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    1ea3660 View commit details
    Browse the repository at this point in the history

  2. Fix colors not being enabled in some forced contexts. 

    Turns out that the color package we use was doing it's own "should
colors be on or not" detection, which interferred with our own
detection. This caused situations where colors were forced on to still
be off (and, maddeningly, would show up in weird contexts because it
dependent on Stdout being not a terminal to break when forced).
    @evanphx
    evanphx committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    4a8b5e1 View commit details
    Browse the repository at this point in the history

  3. Add skip for color test on windows because the test uses posix colors

    @evanphx
    evanphx committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    a72e7ad View commit details
    Browse the repository at this point in the history

  4. Merge pull request #136 from hashicorp/f-color-doc 

    Fix colors not being forced on correctly.
    Evan Phoenix authored Dec 4, 2023
    Configuration menu
    Copy the full SHA
    71d286f View commit details
    Browse the repository at this point in the history
Loading