Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubernetes/apimachinery
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.35.3
Choose a base ref
...
head repository: kubernetes/apimachinery
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.35.4
Choose a head ref
  • 7 commits
  • 5 files changed
  • 4 contributors

Commits on Mar 18, 2026

  1. Fix union validation ratcheting when oldObj is nil

    When oldObj is nil (e.g. new map entry added during update), union
    ratcheting incorrectly treats nil old and empty new as unchanged
    membership, skipping validation entirely. Fix by checking
    reflect.ValueOf(oldObj).IsNil() and disabling ratcheting when
    oldObj is nil, so the new value is fully validated.
    
    This affects Union, DiscriminatedUnion, and ZeroOrOneOfUnion
    (via unionValidate).
    
    Kubernetes-commit: 9a39e5c49faecdf0be53bbdec2d2751799aa774d
    yongruilin authored and k8s-publishing-bot committed Mar 18, 2026
    Configuration menu
    Copy the full SHA
    a128230 View commit details
    Browse the repository at this point in the history
  2. Use IsZero instead of IsNil for union ratcheting check

    - Use reflect.ValueOf(oldObj).IsZero() instead of IsNil() so union
      validation works with non-nilable T (e.g. value types)
    - Remove hasOldValue guard from inner loop conditionals; only check
      at the final ratcheting skip point
    - Add doc comments explaining T is "any" rather than "comparable"
      because union members can be slices
    - Add value-type subtests for Union and DiscriminatedUnion
    
    Co-authored-by: Tim Hockin <thockin@google.com>
    
    Kubernetes-commit: 3d39627cd9815f39fdf8243a60cd0768538e1b1f
    yongruilin authored and k8s-publishing-bot committed Mar 18, 2026
    Configuration menu
    Copy the full SHA
    977ad5b View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2026

  1. Add slice and map union member support with tests

    - Code generator: use len() != 0 for slice/map member extractors
      instead of != nil, so empty slice/map are treated as "not set"
    - Add slice and map members to union test types (both discriminated
      and undiscriminated)
    - Add test coverage for nil vs empty, ratcheting, and nil oldObj
      with slice/map members
    
    Co-authored-by: Tim Hockin <thockin@google.com>
    
    Kubernetes-commit: b6ee759d8ea61a00d391f44b7fcffd06ff158009
    yongruilin authored and k8s-publishing-bot committed Mar 19, 2026
    Configuration menu
    Copy the full SHA
    f933a4d View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2026

  1. Fix backport differences for 1.35 (remove WithOrigin and MarkAlpha)

    Kubernetes-commit: d8a562b6476439fda82827fe1641dc2e307bc52d
    lalitc375 authored and k8s-publishing-bot committed Mar 20, 2026
    Configuration menu
    Copy the full SHA
    b414b94 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2026

  1. Merge pull request #137927 from lalitc375/cherry-pick-137864

    Cherry pick of 137864
    
    Kubernetes-commit: 82a705ccae809af6f50baa096b2568d5fbf531ee
    k8s-publishing-bot committed Apr 9, 2026
    Configuration menu
    Copy the full SHA
    45398ef View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2026

  1. Update github.com/moby/spdystream from v0.5.0 to v0.5.1

    Kubernetes-commit: 7e9c2c8eef26f99aa2f94d8e09d6d32de86c7769
    
    Kubernetes-commit: 1687aa8c94e73c3a1744cb1f4498c0fbc41abe0c
    dims authored and k8s-publishing-bot committed Apr 13, 2026
    Configuration menu
    Copy the full SHA
    6c08bb5 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2026

  1. Merge pull request #138356 from dims/update-moby-spdystream-v0.5.1-1.35

    [1.35] Update github.com/moby/spdystream from v0.5.0 to v0.5.1
    
    Kubernetes-commit: 93828861e0b554581ba647d48efaba1ff579afa3
    k8s-publishing-bot committed Apr 14, 2026
    Configuration menu
    Copy the full SHA
    475c941 View commit details
    Browse the repository at this point in the history
Loading