-
Notifications
You must be signed in to change notification settings - Fork 566
Comparing changes
Open a pull request
base repository: kubernetes/apimachinery
base: v0.35.3
head repository: kubernetes/apimachinery
compare: v0.35.4
- 7 commits
- 5 files changed
- 4 contributors
Commits on Mar 18, 2026
-
Fix union validation ratcheting when oldObj is nil
When oldObj is nil (e.g. new map entry added during update), union ratcheting incorrectly treats nil old and empty new as unchanged membership, skipping validation entirely. Fix by checking reflect.ValueOf(oldObj).IsNil() and disabling ratcheting when oldObj is nil, so the new value is fully validated. This affects Union, DiscriminatedUnion, and ZeroOrOneOfUnion (via unionValidate). Kubernetes-commit: 9a39e5c49faecdf0be53bbdec2d2751799aa774d
Configuration menu - View commit details
-
Copy full SHA for a128230 - Browse repository at this point
Copy the full SHA a128230View commit details -
Use IsZero instead of IsNil for union ratcheting check
- Use reflect.ValueOf(oldObj).IsZero() instead of IsNil() so union validation works with non-nilable T (e.g. value types) - Remove hasOldValue guard from inner loop conditionals; only check at the final ratcheting skip point - Add doc comments explaining T is "any" rather than "comparable" because union members can be slices - Add value-type subtests for Union and DiscriminatedUnion Co-authored-by: Tim Hockin <thockin@google.com> Kubernetes-commit: 3d39627cd9815f39fdf8243a60cd0768538e1b1f
Configuration menu - View commit details
-
Copy full SHA for 977ad5b - Browse repository at this point
Copy the full SHA 977ad5bView commit details
Commits on Mar 19, 2026
-
Add slice and map union member support with tests
- Code generator: use len() != 0 for slice/map member extractors instead of != nil, so empty slice/map are treated as "not set" - Add slice and map members to union test types (both discriminated and undiscriminated) - Add test coverage for nil vs empty, ratcheting, and nil oldObj with slice/map members Co-authored-by: Tim Hockin <thockin@google.com> Kubernetes-commit: b6ee759d8ea61a00d391f44b7fcffd06ff158009
Configuration menu - View commit details
-
Copy full SHA for f933a4d - Browse repository at this point
Copy the full SHA f933a4dView commit details
Commits on Mar 20, 2026
-
Fix backport differences for 1.35 (remove WithOrigin and MarkAlpha)
Kubernetes-commit: d8a562b6476439fda82827fe1641dc2e307bc52d
Configuration menu - View commit details
-
Copy full SHA for b414b94 - Browse repository at this point
Copy the full SHA b414b94View commit details
Commits on Apr 9, 2026
-
Merge pull request #137927 from lalitc375/cherry-pick-137864
Cherry pick of 137864 Kubernetes-commit: 82a705ccae809af6f50baa096b2568d5fbf531ee
Configuration menu - View commit details
-
Copy full SHA for 45398ef - Browse repository at this point
Copy the full SHA 45398efView commit details
Commits on Apr 13, 2026
-
Update github.com/moby/spdystream from v0.5.0 to v0.5.1
Kubernetes-commit: 7e9c2c8eef26f99aa2f94d8e09d6d32de86c7769 Kubernetes-commit: 1687aa8c94e73c3a1744cb1f4498c0fbc41abe0c
Configuration menu - View commit details
-
Copy full SHA for 6c08bb5 - Browse repository at this point
Copy the full SHA 6c08bb5View commit details
Commits on Apr 14, 2026
-
Merge pull request #138356 from dims/update-moby-spdystream-v0.5.1-1.35
[1.35] Update github.com/moby/spdystream from v0.5.0 to v0.5.1 Kubernetes-commit: 93828861e0b554581ba647d48efaba1ff579afa3
Configuration menu - View commit details
-
Copy full SHA for 475c941 - Browse repository at this point
Copy the full SHA 475c941View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.35.3...v0.35.4