Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upVideo Block: Fix drag and drop to create blocks #9493
+2
−2
Conversation
youknowriad
added
the
[Type] Bug
label
Aug 31, 2018
youknowriad
added this to the 3.7 milestone
Aug 31, 2018
youknowriad
self-assigned this
Aug 31, 2018
youknowriad
requested a review
from WordPress/gutenberg-core
Aug 31, 2018
This comment has been minimized.
This comment has been minimized.
|
Might be good to try an e2e test here, but it's not easy to test file drag and drop |
youknowriad
merged commit a3cd589
into
master
Aug 31, 2018
youknowriad
deleted the
fix/video-drag-and-drop
branch
Aug 31, 2018
This comment has been minimized.
This comment has been minimized.
|
Thanks for the fix, @youknowriad ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
youknowriad commentedAug 31, 2018
closes #9484
This PRs fixed a regression in the video block. It was using
editorMediaUploadwhich was deprecated in favor ofmediaUploadTesting instructions