-
-
Notifications
You must be signed in to change notification settings - Fork 129
Improve MCP server: init instructions and helpful database error #3966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,51 @@ | ||||||||||
| /* | ||||||||||
| * Copyright © 2021-present Arcade Data Ltd (info@arcadedata.com) | ||||||||||
| * | ||||||||||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||||||||||
| * you may not use this file except in compliance with the License. | ||||||||||
| * You may obtain a copy of the License at | ||||||||||
| * | ||||||||||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||||||||||
| * | ||||||||||
| * Unless required by applicable law or agreed to in writing, software | ||||||||||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||||||||||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||||||
| * See the License for the specific language governing permissions and | ||||||||||
| * limitations under the License. | ||||||||||
| * | ||||||||||
| * SPDX-FileCopyrightText: 2021-present Arcade Data Ltd (info@arcadedata.com) | ||||||||||
| * SPDX-License-Identifier: Apache-2.0 | ||||||||||
| */ | ||||||||||
| package com.arcadedb.server.mcp.tools; | ||||||||||
|
|
||||||||||
| import java.util.Set; | ||||||||||
| import java.util.TreeSet; | ||||||||||
|
|
||||||||||
| import com.arcadedb.server.ArcadeDBServer; | ||||||||||
| import com.arcadedb.server.ServerDatabase; | ||||||||||
| import com.arcadedb.server.security.ServerSecurityUser; | ||||||||||
|
|
||||||||||
| public class MCPToolUtils { | ||||||||||
|
|
||||||||||
| private MCPToolUtils() { | ||||||||||
| } | ||||||||||
|
|
||||||||||
| /** | ||||||||||
| * Resolves a database by name, throwing an {@link IllegalArgumentException} with the list of databases | ||||||||||
| * accessible to the user when the requested database does not exist — so the LLM can self-correct | ||||||||||
| * without a separate list_databases round-trip. | ||||||||||
| */ | ||||||||||
| public static ServerDatabase resolveDatabase(final ArcadeDBServer server, final ServerSecurityUser user, | ||||||||||
| final String databaseName) { | ||||||||||
|
Comment on lines
+38
to
+39
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The return type must be changed to
Suggested change
|
||||||||||
| if (!server.existsDatabase(databaseName)) { | ||||||||||
| final Set<String> installed = new TreeSet<>(server.getDatabaseNames()); | ||||||||||
| installed.removeIf(db -> !user.canAccessToDatabase(db)); | ||||||||||
| throw new IllegalArgumentException( | ||||||||||
| "Database '" + databaseName + "' does not exist. Available databases: " + installed | ||||||||||
| + ". Use one of these names or call list_databases to refresh the list."); | ||||||||||
| } | ||||||||||
| if (!user.canAccessToDatabase(databaseName)) | ||||||||||
| throw new SecurityException("User '" + user.getName() + "' is not authorized to access database '" + databaseName + "'"); | ||||||||||
| return server.getDatabase(databaseName); | ||||||||||
| } | ||||||||||
| } | ||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The utility should use the
Databaseinterface instead of theServerDatabaseimplementation. This aligns with the return type ofArcadeDBServer.getDatabase()and the expectations of the calling tools.