Fix ActionNode added to an spinning node occasionally throwing std::runtime_error - #113
Closed
perry-reframe wants to merge 1 commit into
Closed
Fix ActionNode added to an spinning node occasionally throwing std::runtime_error#113perry-reframe wants to merge 1 commit into
perry-reframe wants to merge 1 commit into
Conversation
…threaded executor
Collaborator
|
cherry picked only one of the changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an ActionNode is created while the node it uses is already spinning, occasionally it will throw "Callback group has already been added to an executor".
The fix for this is largely replicated from the ServiceNode (here).
This also adds a print to indicate when an ActionClient was created, which mirrors similar behavior in the ServiceNode (here).