Fix --sender flag ignored in publish/upgrade commands - #25016
Merged
stefan-mysten merged 2 commits intoJan 21, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
stefan-mysten
self-requested a review
January 20, 2026 19:04
tuky191
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 20, 2026 22:07 — with
GitHub Actions
Inactive
Contributor
|
Thanks @tuky191, I'll do a few updates and try to merge asap. |
Contributor
|
@tuky191 it appears that I cannot push on this PR. There's two things to fix
to Thanks again for your fix. |
Contributor
Author
|
Hey @stefan-mysten, thanks for looking into this. I have fixed the formatting, the CI should pass now. |
tuky191
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 21, 2026 17:17 — with
GitHub Actions
Inactive
stefan-mysten
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where the
--senderflag was ignored when using--serialize-unsigned-transactionwithsui client publishandsui client upgradecommands.The
TxProcessingArgs::senderfield is documented as:However,
publish_commandandupgrade_commandwere always inferring the sender from gas objects, never checkingprocessing.sender. This caused the UpgradeCap to be transferred to the inferred address instead of the specified sender.This was problematic for workflows where:
The fix makes the implementation match the documented behavior: check
processing.senderfirst and only fall back to gas inference if not specified.Test plan
Added
test_publish_sender_flag_respected_in_serialized_transactionwhich:TestPublishwith--serialize-unsigned-transactionand--sender address_1cargo test -p sui --test cli_tests test_publish_sender_flag_respected_in_serialized_transactionRelease notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
--senderflag is now correctly respected insui client publishandsui client upgradecommands when used with--serialize-unsigned-transaction. Previously, the sender was incorrectly inferred from gas objects, ignoring the--senderflag.