sui-indexer-alt-framework: rename fetch to checkpoint - #25834
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@evan-wall-mysten, please can you explain what those other functions would be used for, why they belong on |
I looked through the
|
amnn
left a comment
There was a problem hiding this comment.
Got it, thanks for clarifying -- the chain_id part makes sense to me, the latest_checkpoint_number part I have more questions for but overall that makes sense for this PR.
Also let's just drop fetch_ from all these names -- it's kind of an empty word for a client trait, which is fine when there's only one function on the trait, but if you have multiple, and they all start with fetch_ then you might as well get rid of it.
Description
This PR renames
fetchtocheckpointin anticipation of future PRs that will add additional methods likechain_idandlatest_checkpoint_number.Test plan
No functional changes.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
IngestionClientTrait::fetchtoIngestionClientTrait::checkpoint.