sui-indexer-alt-framework: add chain_id to CheckpointStreamingClient - #25905
Merged
Conversation
evan-wall-mysten
requested review from
amnn,
emmazzz,
henryachen,
nickvikeras,
tpham-mysten and
wlmyng
March 20, 2026 02:56
evan-wall-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
March 20, 2026 02:56 — with 
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
evan-wall-mysten
force-pushed
the
streaming_client_chain_id
branch
from
March 20, 2026 13:52
b69d989 to
bab10c7
Compare
evan-wall-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
March 20, 2026 13:52 — with
GitHub Actions
Inactive
evan-wall-mysten
force-pushed
the
streaming_client_chain_id
branch
from
March 20, 2026 14:55
bab10c7 to
9a9c876
Compare
evan-wall-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
March 20, 2026 14:55 — with
GitHub Actions
Inactive
evan-wall-mysten
force-pushed
the
streaming_client_chain_id
branch
from
March 20, 2026 15:28
9a9c876 to
c5f81d3
Compare
evan-wall-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
March 20, 2026 15:28 — with
GitHub Actions
Inactive
evan-wall-mysten
force-pushed
the
streaming_client_chain_id
branch
from
March 20, 2026 15:36
c5f81d3 to
7223a55
Compare
evan-wall-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
March 20, 2026 15:36 — with
GitHub Actions
Inactive
amnn
approved these changes
Mar 20, 2026
amnn
left a comment
Contributor
There was a problem hiding this comment.
Looks good modulo minor comments -- remember to update the release notes!
Collaborator
Author
I'll update the release notes in the change that stores the |
evan-wall-mysten
force-pushed
the
streaming_client_chain_id
branch
from
March 20, 2026 18:41
7223a55 to
ef24f28
Compare
evan-wall-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
March 20, 2026 18:41 — with
GitHub Actions
Inactive
evan-wall-mysten
enabled auto-merge (squash)
March 20, 2026 18:59
8 tasks
Contributor
This is not correct. The ingestion and streaming clients and services are part of the indexing framework's public API, i.e. they can be used as standalone components, so changes to their signatures are breaking changes for the indexing framework. Update the release notes section on this PR to indicate that breaking change, and migration guidance, and coordinate with @jessiemongeon1 on review, as this PR has now landed without the necessary update to its description, so it is going to trigger notifications/workflows internally. In future, consider any change to a |
evan-wall-mysten
added a commit
that referenced
this pull request
Mar 26, 2026
) ## Description This PR is a follow up to #25895 and #25905 that 1. stores the `chain_id` per pipeline in the watermark 2. compares the stored `chain_id` to the `chain_id` returned by the streaming and ingestion clients 3. implements the `chain_id` storage for the Postgres and mock store implementations (other impls return the passed in `chain_id` and are no-ops) ## Test plan Adds new `test_chain_id` test cases. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [x] Indexing Framework: Add `Connection::init_chain_id` method to store and retrieve `chain_id`.
jordanjennings-mysten
pushed a commit
that referenced
this pull request
Apr 16, 2026
…25905) ## Description This continues the work started in #25895 by adding a `chain_id` response header that the `CheckpointStreamingClient` reads. The `chain_id` is plumbed through to the `Processor` alongside `checkpoint`. The `processor`'s `Service` currently ignores the `chain_id`. This change depends on #25908. ## Test plan Updated existing unit tests to assert the `chain_id` is passed along with the `checkpoint`. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] Indexing Framework:
jordanjennings-mysten
pushed a commit
that referenced
this pull request
Apr 16, 2026
) ## Description This PR is a follow up to #25895 and #25905 that 1. stores the `chain_id` per pipeline in the watermark 2. compares the stored `chain_id` to the `chain_id` returned by the streaming and ingestion clients 3. implements the `chain_id` storage for the Postgres and mock store implementations (other impls return the passed in `chain_id` and are no-ops) ## Test plan Adds new `test_chain_id` test cases. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [x] Indexing Framework: Add `Connection::init_chain_id` method to store and retrieve `chain_id`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This continues the work started in #25895 by adding a
chain_idresponse header that theCheckpointStreamingClientreads. Thechain_idis plumbed through to theProcessoralongsidecheckpoint.The
processor'sServicecurrently ignores thechain_id.This change depends on #25908.
Test plan
Updated existing unit tests to assert the
chain_idis passed along with thecheckpoint.Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
Processor's receiver to accept newCheckpointEnvelopetype containing thechain_id.