sui-analytics-indexer: implement accepts_chain_id - #26171
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
evan-wall-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
April 9, 2026 12:30 — with 
GitHub Actions
Inactive
evan-wall-mysten
requested review from
a team,
amnn,
emmazzz,
henryachen,
nickvikeras,
tpham-mysten and
wlmyng
April 9, 2026 12:30
amnn
reviewed
Apr 10, 2026
amnn
left a comment
Contributor
There was a problem hiding this comment.
Change looks reasonable to me, but @nickvikeras is the expert here.
evan-wall-mysten
force-pushed
the
accepts_chain_id_analytics
branch
from
April 10, 2026 19:06
4226542 to
8950664
Compare
evan-wall-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
April 10, 2026 19:06 — with
GitHub Actions
Inactive
nickvikeras
reviewed
Apr 14, 2026
nickvikeras
approved these changes
Apr 14, 2026
8 tasks
evan-wall-mysten
added a commit
that referenced
this pull request
Apr 15, 2026
## Description Moves the `sui-analytics-indexer`'s `accepts_chain_id` impl (added in #26171) into `sui-indexer-alt-object-store` so it can be used in both locations. ## Test plan Added new unit tests. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [x] Indexing Framework: Implement `accepts_chain_id` in object store
jordanjennings-mysten
pushed a commit
that referenced
this pull request
Apr 16, 2026
## Description
Replaced the `accepts_chain_id` stub with an impl that stores the
32-byte `chain_id` at `_metadata/chain_id/{pipeline_task}`. Uses
`PutMode::Create` to claim the file on first call; on `AlreadyExists`,
reads it back and returns whether it matches.
## Test plan
Added new unit tests.
---
## Release notes
Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.
For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.
- [ ] Protocol:
- [ ] Nodes (Validators and Full nodes):
- [ ] gRPC:
- [ ] JSON-RPC:
- [ ] GraphQL:
- [ ] CLI:
- [ ] Rust SDK:
- [x] Indexing Framework: Implement `accepts_chain_id` in analytics
indexer.
jordanjennings-mysten
pushed a commit
that referenced
this pull request
Apr 16, 2026
## Description Moves the `sui-analytics-indexer`'s `accepts_chain_id` impl (added in #26171) into `sui-indexer-alt-object-store` so it can be used in both locations. ## Test plan Added new unit tests. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [x] Indexing Framework: Implement `accepts_chain_id` in object store
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaced the
accepts_chain_idstub with an impl that stores the 32-bytechain_idat_metadata/chain_id/{pipeline_task}. UsesPutMode::Createto claim the file on first call; onAlreadyExists, reads it back and returns whether it matches.Test plan
Added new unit tests.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
accepts_chain_idin analytics indexer.