Skip to content

rpc-index: track coin and address balances separately - #26403

Merged
bmwill merged 1 commit into
MystenLabs:mainfrom
bmwill:grpc-balance-indexing
Apr 28, 2026
Merged

rpc-index: track coin and address balances separately#26403
bmwill merged 1 commit into
MystenLabs:mainfrom
bmwill:grpc-balance-indexing

Conversation

@bmwill

@bmwill bmwill commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

This changes how balances are tracked in the rpc-indexes to separate coin and address balances in order to remove a possible inconsistency in the data returned due to a race between two reads from separate DBs.

This also bumps the CURRENT_DB_VERSION to 4 to trigger reindexing. The main reason for this is to explicitly fix some inaccurate indexes that exist on fullnodes in the wild due to a bug introduced in baae1c4ded and later fixed in 89deab497d.

Description

Describe the changes or additions included in this PR.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC: rpc-index DB version has been updated to 4. This means that on startup re-indexing will be required and can take some time depending on the amount of object history present on the node.
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • Indexing Framework:

@bmwill
bmwill requested a review from nickvikeras April 28, 2026 16:04
@bmwill
bmwill temporarily deployed to sui-typescript-aws-kms-test-env April 28, 2026 16:04 — with GitHub Actions Inactive
@vercel

vercel Bot commented Apr 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sui-docs Ready Ready Preview, Comment Apr 28, 2026 8:20pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
multisig-toolkit Ignored Ignored Preview Apr 28, 2026 8:20pm
sui-kiosk Ignored Ignored Preview Apr 28, 2026 8:20pm

Request Review

This changes how balances are tracked in the rpc-indexes to separate
coin and address balances in order to remove a possible inconsistency in
the data returned due to a race between two reads from separate DBs.

This also bumps the CURRENT_DB_VERSION to 4 to trigger reindexing. The
main reason for this is to explicitly fix some inaccurate indexes that
exist on fullnodes in the wild due to a bug introduced in `baae1c4ded`
and later fixed in `89deab497d`.
@bmwill
bmwill force-pushed the grpc-balance-indexing branch from 9190c1b to c87d0be Compare April 28, 2026 20:15
@bmwill
bmwill temporarily deployed to sui-typescript-aws-kms-test-env April 28, 2026 20:15 — with GitHub Actions Inactive
@bmwill
bmwill merged commit a79c31d into MystenLabs:main Apr 28, 2026
56 checks passed
@bmwill
bmwill deleted the grpc-balance-indexing branch April 28, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants