rpc-index: track coin and address balances separately - #26403
Merged
Conversation
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
April 28, 2026 16:04 — with
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
nickvikeras
approved these changes
Apr 28, 2026
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
April 28, 2026 16:57 — with
GitHub Actions
Inactive
This changes how balances are tracked in the rpc-indexes to separate coin and address balances in order to remove a possible inconsistency in the data returned due to a race between two reads from separate DBs. This also bumps the CURRENT_DB_VERSION to 4 to trigger reindexing. The main reason for this is to explicitly fix some inaccurate indexes that exist on fullnodes in the wild due to a bug introduced in `baae1c4ded` and later fixed in `89deab497d`.
bmwill
force-pushed
the
grpc-balance-indexing
branch
from
April 28, 2026 20:15
9190c1b to
c87d0be
Compare
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
April 28, 2026 20:15 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes how balances are tracked in the rpc-indexes to separate coin and address balances in order to remove a possible inconsistency in the data returned due to a race between two reads from separate DBs.
This also bumps the CURRENT_DB_VERSION to 4 to trigger reindexing. The main reason for this is to explicitly fix some inaccurate indexes that exist on fullnodes in the wild due to a bug introduced in
baae1c4dedand later fixed in89deab497d.Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
4. This means that on startup re-indexing will be required and can take some time depending on the amount of object history present on the node.