Skip to content

[framework] future proofing type_name in coin - #27067

Merged
damirka merged 2 commits into
mainfrom
ds/coin-def-ids
Jun 25, 2026
Merged

[framework] future proofing type_name in coin#27067
damirka merged 2 commits into
mainfrom
ds/coin-def-ids

Conversation

@damirka

@damirka damirka commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Description

Prep work for init on upgrade.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol: use defining_ids in sui::coin
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • Indexing Framework:

@damirka damirka self-assigned this Jun 25, 2026
@damirka
damirka requested a review from a team as a code owner June 25, 2026 19:43
@damirka
damirka temporarily deployed to sui-typescript-aws-kms-test-env June 25, 2026 19:43 — with GitHub Actions Inactive
@vercel

vercel Bot commented Jun 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sui-docs Ready Ready Preview, Comment Jun 25, 2026 7:47pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
multisig-toolkit Ignored Ignored Preview Jun 25, 2026 7:47pm
sui-kiosk Ignored Ignored Preview Jun 25, 2026 7:47pm

Request Review

@tnowacki tnowacki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
cc @tzakian for init on upgrade work

@damirka
damirka merged commit 43e3183 into main Jun 25, 2026
65 of 66 checks passed
@damirka
damirka deleted the ds/coin-def-ids branch June 25, 2026 20:18
jessiemongeon1 added a commit that referenced this pull request Jul 7, 2026
…handling (#27165)

## Summary
- Strip internal PR title/author lines (e.g. `PR #27067: [framework]
future proofing type_name in coin by @damir (Damir Shamanaev)`) from
generated release notes so review metadata does not appear on the
published page.
- Document SDK v2 behavior change for non-existent objects in
`common-errors.mdx`: `getObject` now throws instead of returning a `{
data, error }` wrapper, and multi-get methods like `getObjects` return
`(Object | Error)[]` instead of `SuiObjectResponse[]`.

## Test plan
- [ ] Run `node docs/site/src/shared/js/convert-release-notes.cjs` and
verify PR title/author lines are stripped from output
- [ ] Verify `common-errors.mdx` renders correctly in the docs site
- [ ] Confirm code examples in the new section are syntactically correct

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants