Skip to content

Add scalafmt plugin to scalatra generator#23463

Open
volcano303 wants to merge 1 commit intoOpenAPITools:masterfrom
volcano303:add-scalafmt-scalatra
Open

Add scalafmt plugin to scalatra generator#23463
volcano303 wants to merge 1 commit intoOpenAPITools:masterfrom
volcano303:add-scalafmt-scalatra

Conversation

@volcano303
Copy link
Copy Markdown
Contributor

@volcano303 volcano303 commented Apr 7, 2026

Adds scalafmt (Scalafmt 3.10.6, Scala 2.12 dialect) and sbt-scalafmt plugin (2.5.6) to the scalatra generator, following the same pattern as #23273 (scala-sttp4) and #23378 (scala-sttp4-jsoniter).

The sbt-scalafmt plugin line is appended to the existing project/plugins.sbt.

Partially addresses #23274

cc @clasnake @shijinkui @ramzimaalej @chameleon82 @Bouillie @Fish86

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Add Scalafmt support to the Scalatra server generator by generating .scalafmt.conf and enabling the sbt-scalafmt plugin, so new projects are ready for auto-formatting. Updates the Scalatra sample to include the config and plugin.

  • New Features

    • Generate .scalafmt.conf from scalafmt.mustache (Scalafmt 3.10.6, Scala 2.12 dialect).
    • Append org.scalameta sbt-scalafmt 2.5.6 to project/plugins.sbt in the template and sample.
    • Register the new config file in ScalatraServerCodegen via SupportingFile.
  • Migration

    • No breaking changes. New Scalatra projects include the formatter; run sbt scalafmtAll to format.

Written for commit 2159b6b. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 12 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant