Add some process metrics for GOOS=darwin#107
Conversation
db59fa8 to
46180c6
Compare
46180c6 to
833ad3a
Compare
|
@valyala asked for your review since the PR adds a lot of files to the vendor. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #107 +/- ##
=======================================
Coverage 88.68% 88.68%
=======================================
Files 12 12
Lines 1388 1388
=======================================
Hits 1231 1231
Misses 106 106
Partials 51 51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I don't want merging a pull request, which brings so big amounts of third-party code for the sake of exposing a few system metrics on MacOS. Please search for alternatives, which do not depend on hundreds of external code files. Is it possible to add the missing metrics by reading them from system files like it is done for these metrics on Linux at https://github.com/VictoriaMetrics/metrics/blob/master/process_metrics_linux.go ? |
Adds support for process metrics on MacOS\Darwin. I added only those that do not require CGO.
process_start_time_secondsFixes #75
Inspired by https://github.com/prometheus/client_golang/blob/main/prometheus/process_collector_darwin.go