Skip to content

Fix: Adjust Site URL Styles to Prevent Overflow in Pre-Publish Component#64745

Merged
Mamaduka merged 2 commits intoWordPress:trunkfrom
imrraaj:fix/pre-publish-panel-url-overflow
Aug 26, 2024
Merged

Fix: Adjust Site URL Styles to Prevent Overflow in Pre-Publish Component#64745
Mamaduka merged 2 commits intoWordPress:trunkfrom
imrraaj:fix/pre-publish-panel-url-overflow

Conversation

@imrraaj
Copy link
Copy Markdown
Contributor

@imrraaj imrraaj commented Aug 23, 2024

What?

This fix stops the URL from overflowing in the panel body in the Pre Publish Panel. URL now wraps around the container.

Why?

Fixes #64730

How?

adding the following styles
word-break: break-word; to .components-site-home

Testing Instructions

  1. Checkout the PR in the local WordPress installation
  2. Create a New Post
  3. Click Publish; the Pre Publish screen should be shown.
  4. Notice how the URL is broken into multiple lines if the site URL cannot fit properly.

Screenshots or screencast

Before

Screen.Recording.2024-08-23.at.2.20.43.PM.mov

After

Screen.Recording.2024-08-23.at.6.28.05.PM.mov

@imrraaj imrraaj marked this pull request as ready for review August 23, 2024 13:56
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 23, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: imrraaj <imrraaj@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: vcanales <vcanales@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Feature] Document Settings Document settings experience labels Aug 24, 2024
@Mamaduka
Copy link
Copy Markdown
Member

I think we also need to add flex-shrink: 0 to the components-site-icon class to prevent the logo from shrinking based on the domain size.

Before After
CleanShot 2024-08-24 at 10 53 50 CleanShot 2024-08-24 at 10 54 03

@t-hamano t-hamano self-requested a review August 24, 2024 07:29
Copy link
Copy Markdown
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the fix 👍 Edit: I missed the previous comment. Sure, the logo shrinking needs to be fixed.

@imrraaj
Copy link
Copy Markdown
Contributor Author

imrraaj commented Aug 26, 2024

I have added the flex-shrink property. PR is ready for review.

@Mamaduka Mamaduka merged commit 1195cb2 into WordPress:trunk Aug 26, 2024
@github-actions github-actions bot added this to the Gutenberg 19.2 milestone Aug 26, 2024
bph pushed a commit to bph/gutenberg that referenced this pull request Aug 31, 2024
…ent (WordPress#64745)


Co-authored-by: imrraaj <imrraaj@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: vcanales <vcanales@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Document Settings Document settings experience [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Site URL can overflow the pre-publish component when the URL exceeds a certain length

3 participants