Migrate db.sql.latency metric to db.client.operation.duration

[XSAM]

Part of #388

[codecov]

Codecov Report

Attention: Patch coverage is 90.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 85.3%. Comparing base (757add3) to head (4c0e9f8).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
instruments.go	55.5%	3 Missing and 1 partial ⚠️
internal/semconv/attributes.go	86.9%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##            main    #480     +/-   ##
=======================================
+ Coverage   85.1%   85.3%   +0.1%     
=======================================
  Files         16      16             
  Lines        855     906     +51     
=======================================
+ Hits         728     773     +45     
- Misses       103     107      +4     
- Partials      24      26      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull Request Overview

This PR migrates the legacy db.sql.latency metric to the new db.client.operation.duration metric, while supporting multiple semantic convention stability options. Key changes include:

• Introducing new functions recordLegacyLatency and recordDuration to handle legacy and new metric formats.
• Updating the recordMetric function to switch between legacy and new behavior based on the OTEL_SEMCONV_STABILITY_OPT_IN setting.
• Adjusting tests and instrument creation (including newMockConfig invocations) to accommodate the new metric signature and parameters.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
utils.go	Introduces recordLegacyLatency, recordDuration, and updates recordMetric conversion logic.
tx_test.go, stmt_test.go, rows_test.go, connector_test.go, conn_test.go	Updates newMockConfig calls to pass an additional nil parameter.
instruments.go	Replaces the legacy 'latency' instrument with new 'legacyLatency' and 'duration' instruments.
README.md, CHANGELOG.md	Updates metric descriptions and documentation to reflect the migration.
internal/semconv/*	Updates error type attribution and attributes as needed by the new semantic conventions.

Comments suppressed due to low confidence (1)

tx_test.go:98

• The updated newMockConfig calls now include an extra nil parameter. It would be helpful to update the function's documentation or inline comment to explain the purpose of this new parameter.

cfg := newMockConfig(t, tracer, nil)

[Copilot]

Pull Request Overview

This PR migrates the legacy db.sql.latency metric to the new db.client.operation.duration metric following the OpenTelemetry semantic conventions while still allowing for legacy behavior based on a stability opt‐in setting.

• Introduces two new functions, recordLegacyLatency and recordDuration, to separately handle legacy and new metric formats.
• Updates recordMetric to switch between legacy, new, or combined metric recording based on cfg.SemConvStabilityOptIn and updates tests and documentation to support the metric migration.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
utils.go	Updates metric recording functions and abstracts legacy/new recording strategies.
tx_test.go, stmt_test.go, rows_test.go, connector_test.go, conn_test.go	Updates calls to newMockConfig with an extra parameter.
internal/semconv/attributes.go, attributes_test.go	Adds error type attribute conversion for new metrics.
instruments.go, instruments_test.go	Renames legacy latency instrument and creates a new duration instrument.
README.md, CHANGELOG.md	Documents and logs the migration to the new metric.

Comments suppressed due to low confidence (1)

utils.go:72

• The code uses 'driver.ErrSkip' but the 'database/sql/driver' package is not imported, which may lead to a compilation error. Consider adding the missing import.

if cfg.DisableSkipErrMeasurement && err == driver.ErrSkip {