Brightcove player component#1052
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
Please add here |
There was a problem hiding this comment.
Up to you but a simpler or more focused example might be easier to comprehend.
|
Everything looks good, but we need to fix CI tests. Please see comments above. Otherwise LGTM on my part. |
|
CLAs look good, thanks! |
|
The tests are passing now. |
|
Awesome. Last request: could you please squash the commits? |
bb8e8b1 to
9a0f608
Compare
|
Squashed commits. |
|
LGTM |
|
Merged. Thanks a lot! |
This is an
amp-brightcovecomponent to implement a Brightcove player as outlined in #1048.Closes #1048.