Add custom writer for area - #7
Merged
Merged
Conversation
Member
|
Hi @Brookke, I just saw this PR again, is it done? It's currently marked as a draft, so I didn't review it :) |
lammel
reviewed
Apr 20, 2023
lammel
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me and should allow flexible use on any writer
Codecov Report
@@ Coverage Diff @@
## main #7 +/- ##
========================================
- Coverage 4.31% 4.06% -0.25%
========================================
Files 4 4
Lines 116 123 +7
========================================
Hits 5 5
- Misses 110 117 +7
Partials 1 1
|
MarvinJWendt
marked this pull request as ready for review
June 18, 2023 16:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed in order to support pterm/pterm#261