Skip to content

Reorganization - #4

Merged
martindurant merged 9 commits into
masterfrom
dev
Nov 1, 2016
Merged

Reorganization#4
martindurant merged 9 commits into
masterfrom
dev

Conversation

@martindurant

Copy link
Copy Markdown
Member

No description provided.

Martin Durant added 4 commits October 31, 2016 15:01
Add bson to travis script

try again...

and again

Alternative bsons

final?

absolute path reference
@martindurant

Copy link
Copy Markdown
Member Author

@mrocklin , thoughts, please, on what else needs to be done before making an entry on pypi and then conda-forge (the first is a prerequisite of the second, correct?).

Comment thread .travis.yml Outdated
install:
- pip install tox
# Install conda
- wget http://repo.continuum.io/miniconda/Miniconda-latest-Linux-x86_64.sh -O miniconda.sh

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I've had problems with http:// and conda recently. Recommend to switching to https://

Comment thread README.rst Outdated
JSON or TSV (without the overhead of JVM startup). Performance has not
yet been optimized, but it's useful for debugging and quick viewing of
data in files.
fast is a python implementation of the `parquet

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo fast -> fastparquet

Comment thread README.rst Outdated

parquet-python has been tested on python 2.7, 3.4, and 3.5. It depends
on ``thrift`` (0.9) and ``python-snappy`` (for snappy compressed files).
Since the second week of October, this fork of `parquet-python`_ has been

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend having a history section towards the end that includes this information.

I suspect that most people reading the readme will not care about the recent history.

Comment thread README.rst Outdated
- Implement writing
- performance evaluation and optimization (i.e. how does it compare to
the c++, java implementations)
> pip install git+https://github.com/martindurant/fastparquet

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown uses double colons for indentation:

Install from GitHub::

   pip install git+https://github.com/martindurant/fastparquet

That means two colons on the previous line, then indent by three spaces (wonky, I know)

Comment thread README.rst Outdated

.. code-block:: python

import fastparquet

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend using from fastparquet import ParquetFile in future examples so that if we need to change the name we'll have to rename less

@mrocklin

mrocklin commented Nov 1, 2016

Copy link
Copy Markdown
Member

You'll want to reivew the MANIFEST.in file. This should list all files that will go into the package on PyPI. I recommend looking at dask's.

Here is the release procedure I use for dask:

  • Tag commit
git tag -a x.x.x -m 'Version x.x.x'
  • and push to github
git push dask master --tags
  • Upload to PyPI
git clean -xfd
python setup.py register sdist bdist_wheel --universal
twine upload dist/*

@mrocklin

mrocklin commented Nov 1, 2016

Copy link
Copy Markdown
Member

Note that git clean will remove all files in the directory that are not part of the repository, so you may want to move notebooks, extra data, or benchmarks outside first or do this in a clean clone.

@martindurant
martindurant merged commit ad2c488 into master Nov 1, 2016
@martindurant
martindurant deleted the dev branch November 1, 2016 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants