Skip to content

Async-streams: Emit AsyncIteratorStateMachine attribute on async-iterator methods#31553

Merged
jcouv merged 1 commit intodotnet:masterfrom
jcouv:add-attribute
Dec 7, 2018
Merged

Async-streams: Emit AsyncIteratorStateMachine attribute on async-iterator methods#31553
jcouv merged 1 commit intodotnet:masterfrom
jcouv:add-attribute

Conversation

@jcouv
Copy link
Copy Markdown
Member

@jcouv jcouv commented Dec 5, 2018

Previously we emitted both AsyncStateMachine and IteratorStateMachine attributes, but LDM decided to go with a new attribute instead to avoid ambiguity.

Async-streams umbrella: #24037

@jcouv jcouv added this to the 16.0.P2 milestone Dec 5, 2018
@jcouv jcouv self-assigned this Dec 5, 2018
@jcouv jcouv requested a review from a team as a code owner December 5, 2018 15:45
@jcouv
Copy link
Copy Markdown
Member Author

jcouv commented Dec 5, 2018

FYI @stephentoub

Copy link
Copy Markdown
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1)

@jcouv
Copy link
Copy Markdown
Member Author

jcouv commented Dec 5, 2018

@dotnet/roslyn-compiler for a second review. Tiny PR. Thanks

@jcouv jcouv merged commit d3d10fb into dotnet:master Dec 7, 2018
@jcouv jcouv deleted the add-attribute branch December 7, 2018 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants