Skip to content

feat: api history#73

Merged
dsanders11 merged 47 commits intomainfrom
feat/api-history
Jul 17, 2024
Merged

feat: api history#73
dsanders11 merged 47 commits intomainfrom
feat/api-history

Conversation

@piotrpdev
Copy link
Copy Markdown
Contributor

@piotrpdev piotrpdev commented Jun 19, 2024 •
edited
Loading

Note

This PR is part of the 2024 Electron GSoC [Project] [Proposal].

Linting script for the API History blocks in electron/docs/*.md.

@dsanders11 @erickzhao @VerteDinde

@piotrpdev piotrpdev requested a review from a team as a code owner June 19, 2024 01:36
@piotrpdev piotrpdev added the ✨ enhancement New feature or request label Jun 19, 2024
dsanders11
dsanders11 requested changes Jun 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a first pass at review, leaving it for now to allow for discussion on the larger change being requested.

@piotrpdev piotrpdev requested a review from dsanders11 June 19, 2024 17:13
@piotrpdev piotrpdev mentioned this pull request Jul 9, 2024
Merged
2 tasks
dsanders11
dsanders11 requested changes Jul 16, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments but I think we're getting close!

@piotrpdev piotrpdev requested a review from dsanders11 July 17, 2024 01:59
dsanders11
dsanders11 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed two final commits and gonna merge:

  • Would prefer to retain the .md extension instead of .md.api-history
  • Restored yarn.lock and did yarn install myself to align with our policy on maintainers making lockfile changes. This ended up bumping some versions of things which seems fine.

@piotrpdev
Copy link
Copy Markdown
Contributor Author

piotrpdev commented Jul 17, 2024

Would prefer to retain the .md extension instead of .md.api-history

I renamed it because using .md breaks lint-roller-markdown-links.spec.ts.

Restored yarn.lock and did yarn install myself to align with our policy on maintainers making lockfile changes. This ended up bumping some versions of things which seems fine.

👍

@dsanders11
Copy link
Copy Markdown
Member

dsanders11 commented Jul 17, 2024

I renamed it because using .md breaks

I see that now. 😅 Pushed a commit to ignore it in those tests.

@dsanders11
chore: retain .md extension
84a3dbc 
Signed-off-by: David Sanders <dsanders11@ucsbalum.com>
@dsanders11
chore: maintainer committed yarn.lock
4d42ea2 
Signed-off-by: David Sanders <dsanders11@ucsbalum.com>
@dsanders11
test: ignore API history files in links spec
4f988c9 
Signed-off-by: David Sanders <dsanders11@ucsbalum.com>
@dsanders11 dsanders11 merged commit 3030970 into main Jul 17, 2024
@dsanders11 dsanders11 deleted the feat/api-history branch July 17, 2024 03:51
@continuous-auth
Copy link
Copy Markdown

continuous-auth bot commented Jul 17, 2024

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erickzhao erickzhao erickzhao approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

Assignees

No one assigned

Labels

released ✨ enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@piotrpdev @dsanders11 @VerteDinde @erickzhao