cmd/evm: speed up TestEvmRun - #23120
Draft
lupin012 wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15153
Problem:
TestEvmRuntook ~2.9s. Two of its four sub-cases pass--bench, which callstesting.Benchmark: it loops until it accumulates ~1s of measured time (the default benchtime), no matter how trivial the executed bytecode is. The default cannot be overridden from the command line, because the re-exec'd child parses flags with urfave/cli, not with thetestingpackage.Two changes (test code only):
TestMainsets-test.benchtimefrom theEVM_TEST_BENCHTIMEenv variable. It is opt-in: without the variable the 1s default stays.TestEvmRunpasses1x(a single measured iteration, deterministic) per child via a new optionalEnvfield oncmdtest.TestCmd. 2.94s → 0.80s.cmd/evmpackage still passes).Question for reviewers: at 0.22s the test is well below the 500ms threshold that motivated its exclusion from short mode in #15144. Can we also remove the
testing.Short()skip and bring it back into the short suite?