rpc/jsonrpc: return requested numeric selector in erigon_blockNumber - #23127
Open
Sahil-4555 wants to merge 1 commit into
Open
rpc/jsonrpc: return requested numeric selector in erigon_blockNumber#23127Sahil-4555 wants to merge 1 commit into
Sahil-4555 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where
erigon_blockNumberaccepted a numeric block number parameter (e.g.["0x1"]) but ignored it, returning the latest executed block height instead.BlockNumber()parses numeric parameters intorpcBlockNum. However, becauserpc.LatestExecutedBlockNumberwas not an explicitcasein theswitch rpcBlockNum, bothrpc.LatestExecutedBlockNumber(-5) and valid positive numeric block selectors (such as1or7) fell through todefault:, which unconditionally calledrpchelper.GetLatestExecutedBlockNumber(tx).case rpc.LatestExecutedBlockNumber, rpc.PendingBlockNumber:branch that callsrpchelper.GetLatestExecutedBlockNumber(tx).default:to setblockNum = uint64(rpcBlockNum), returning the requested numeric block number.TestErigonBlockNumberunit tests covering omitted parameters, named tags ("latest","earliest"), and numeric selectors ("0x0","0x1","0x7").Closes #23118