Skip to content

Qt: fix receive request model handling - #1838

Merged
reubenyap merged 1 commit into
masterfrom
cursor/critical-bug-inspection-8fd6
May 26, 2026
Merged

Qt: fix receive request model handling#1838
reubenyap merged 1 commit into
masterfrom
cursor/critical-bug-inspection-8fd6

Conversation

@cursor

@cursor cursor Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

PR intention

Fix critical receive-request dialog crashes and filtered recent-request history mis-handling in the Qt wallet.

Code changes brief

  • Pass the full WalletModel to ReceiveRequestDialog and derive the options model from it so address-type validation does not dereference an uninitialized pointer.
  • Map recent-request selections from the filter proxy to source rows before copying/deleting.
  • Remove selected source rows in descending order so filtered multi-delete cannot erase the wrong persisted requests.
Open in Web View Automation 

Co-authored-by: Reuben Yap <reuben@firo.org>
@reubenyap
reubenyap marked this pull request as ready for review May 14, 2026 13:35

@navidR navidR left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reubenyap
reubenyap merged commit cd70188 into master May 26, 2026
43 of 50 checks passed
@reubenyap
reubenyap deleted the cursor/critical-bug-inspection-8fd6 branch May 26, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants