Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

feat(bigquery): support IAM conditions in datasets in Java client.#3602

Merged
whuffman36 merged 8 commits into
mainfrom
iam-conditions
Jan 2, 2025
Merged

feat(bigquery): support IAM conditions in datasets in Java client.#3602
whuffman36 merged 8 commits into
mainfrom
iam-conditions

Conversation

@whuffman36
Copy link
Copy Markdown
Contributor

@whuffman36 whuffman36 commented Dec 9, 2024 •
edited
Loading

This PR enables the use of IAM conditions when accessing a dataset through the create, update, and get API endpoints. The following changes are necessary:

  • Add in a new Expr type in the Acl class for expressing the access conditions
  • Create a new DatasetOption field to set the access policy version
  • Set the access policy version before sending the rpc to the backend when applicable

Buganizer link: b/374156746

@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/java-bigquery API. labels Dec 9, 2024
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Dec 10, 2024
@whuffman36 whuffman36 marked this pull request as ready for review December 10, 2024 02:50
@whuffman36 whuffman36 requested review from a team, Neenu1995, PhongChuong and shollyman and removed request for Neenu1995 December 10, 2024 02:50
@whuffman36 whuffman36 self-assigned this Dec 10, 2024
shollyman
shollyman reviewed Dec 11, 2024
View reviewed changes
Comment thread google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/Acl.java
bqExpr.getExpression(), bqExpr.getTitle(), bqExpr.getDescription(), bqExpr.getLocation());
}

@Override
Copy link
Copy Markdown
Contributor

@shollyman shollyman Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include toString() as well as the normal methods like equals and hashcode?