fix #187223

[Kalmaegi]

fix #187223

[jrieken]

Thanks, this is looking good but turns out the variable isn't needed at all and can be removed. So, please update the PR with deletion of the variable. Thanks

[Kalmaegi]

Thanks, this is looking good but turns out the variable isn't needed at all and can be removed. So, please update the PR with deletion of the variable. Thanks

Yes, I found that there are no places where I use it anymore XD

[jrieken]

Thanks!

[Kalmaegi]

Thanks!

Thank you! I will test thoroughly for other unused variables and submit a PR to remove them.

[Kalmaegi]

@jrieken sorry I messed up, I took a closer look at the code again and find

vscode/src/vs/workbench/contrib/inlineChat/browser/inlineChatLivePreviewWidget.ts

Line 106 in 4789314

[colorRegistry.diffRemoved, inlineChatDiffRemoved],

This color should be used in a new feature: https://code.visualstudio.com/updates/v1_79#_contributions-to-extensions, I don't have access to copilot chat at the moment, so I can't test it, but it looks like it's definitely there

[jrieken]

No worries, this will still work. We only modified the file that checks CSS file and whether a variable is defined or not. Nothing is broken and the change is correct

[Kalmaegi]

No worries, this will still work. We only modified the file that checks CSS file and whether a variable is defined or not. Nothing is broken and the change is correct

thanks! One of the influences I've found so far is that I typed "inlineChatDiff.removed" in the "workbench.colorCustomizations" configuration in setting.json and there was no variable hint, and other issues have not been found yet

[Kalmaegi]

by the way, I find that the test cases here are currently failing:

vscode/src/vs/workbench/contrib/themes/test/node/colorRegistry.releaseTest.ts

Line 39 in 2cbf01b

suite('Color Registry', function () {