Merged
Conversation
8 tasks
hediet
approved these changes
Jan 4, 2024
Member
|
Thanks! |
bpasero
approved these changes
Jan 4, 2024
If I understand correctly, this is just a hack to support IE. However, IE is no longer supported, so this is no longer necessary.
74a14f3 to
490e7ba
Compare
Contributor
Author
|
Correct me if I’m wrong, but the CI failure appears to be unrelated to these changes. |
Member
|
Yes, I believe so too |
hediet
added a commit
that referenced
this pull request
Jan 15, 2024
hediet
added a commit
that referenced
this pull request
Jan 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I understand correctly, this is just a hack to support IE. However, IE is no longer supported, so this is no longer necessary.
This is getting somewhat in the way of #194609.