Update to rocksdb dependency to 0.16.0 - #4442
Merged
Merged
Conversation
mina86
requested review from
bowenwang1996,
frol,
khorolets,
maxzaver and
olonho
as code owners
June 30, 2021 17:00
Contributor
Author
|
I’ve given cursory look at the commits between 0.15 and 0.16 and didn’t notice anything breaking. I’ve run |
Contributor
|
@mina86 The failing is about cargo-deny. We disallow any crate in Cargo.lock have two different versions. When there's third party dependency cause this (in this case, rocksdb 0.16), add the exception to |
bowenwang1996
approved these changes
Jul 1, 2021
mina86
enabled auto-merge (squash)
July 1, 2021 23:20
ailisp
approved these changes
Jul 5, 2021
Contributor
|
@olonho @frol @khorolets please review this PR |
khorolets
approved these changes
Jul 5, 2021
Contributor
Author
|
Haha. The number of reviewers is too damn high. ;) @olonho, could you also approve? |
olonho
reviewed
Jul 7, 2021
olonho
reviewed
Jul 7, 2021
olonho
approved these changes
Jul 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #3266