client: introduce near_build_info metric with node’s release info - #6680
Merged
Conversation
Introduce near_build_info with a constant value 1 which exports node’s build information as labels. Specifically, release, build and rust version are exported. See [1] for description how this metric can be used. [1] https://www.robustperception.io/exposing-the-software-version-to-prometheus While at it, set near_node_protocol_version and near_node_db_version only once (since they are always set to the same value) rather than doing so each time statistics are printed. Added bonus of this is that those metrics are now set immediately when node starts rather than the first time the stats info line is printed in the log. Issue: near#5979
near_build_info metric with node’s release info
jakmeier
approved these changes
Apr 25, 2022
jakmeier
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Interesting approach over all, I appreciate that you included the link to explain why it is done this way!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce near_build_info with a constant value 1 which exports
node’s build information as labels. Specifically, release, build and
rust version are exported. See [1] for description how this metric
can be used.
[1] https://www.robustperception.io/exposing-the-software-version-to-prometheus
While at it, set near_node_protocol_version and near_node_db_version
only once (since they are always set to the same value) rather than
doing so each time statistics are printed. Added bonus of this is
that those metrics are now set immediately when node starts rather
than the first time the stats info line is printed in the log.
Issue: #5979