Skip to content

network: deprecate near_peer_message_received_total #7548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
near-bulldozer merged 1 commit into from
Sep 5, 2022
Merged

network: deprecate near_peer_message_received_total #7548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@
* Added `near_peer_message_sent_by_type_bytes` and
`near_peer_message_sent_by_type_total` Prometheus metrics measuring
size and number of messages sent to peers.
* `near_peer_message_received_total` Prometheus metric is now deprecated.
Instead of it aggregate `near_peer_message_received_by_type_total` metric
instead. For example, to get total rate of received messages use
`sum(rate(near_peer_message_received_by_type_total{...}[5m]))`.

## 1.28.0 [2022-07-27]

Expand Down
3 changes: 2 additions & 1 deletion chain/network/src/stats/metrics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,11 @@ pub(crate) static PEER_MESSAGE_RECEIVED_BY_TYPE_BYTES: Lazy<IntCounterVec> = Laz
)
.unwrap()
});
// TODO(mina86): This has been deprecated in 1.30. Remove at 1.32 or so.

@mm-near mm-near Sep 5, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for leaving such comments !

pub(crate) static PEER_MESSAGE_RECEIVED_TOTAL: Lazy<IntCounter> = Lazy::new(|| {
try_create_int_counter(
"near_peer_message_received_total",
"Number of messages received from peers",
"Deprecated; aggregate near_peer_message_received_by_type_total instead",
)
.unwrap()
});
Expand Down