added STUN-based TIER1 self-discovery - #8472
Merged
Merged
Conversation
mm-near
approved these changes
Feb 1, 2023
| } | ||
| // Check that we have received non-zero responses and that they are consistent. | ||
| if node_ips.len() == 0 { | ||
| vec![] |
Contributor
There was a problem hiding this comment.
this means that we cannot get the IP address, right?
Is it visible somewhere?
I wonder if we should somehow export the current ip (in prometheus?)
Contributor
Author
There was a problem hiding this comment.
It is exposed on the debug page, as AccountData. It is not really feasible to expose it in prometheus (gauge cannot have a string value), unless we abuse the system.
nikurt
pushed a commit
that referenced
this pull request
Feb 6, 2023
If no public_addrs are configured, a validator node will try to query STUN servers to discover its own IP. By default a list of public STUN servers provided by Google is used, bu the user is recommended to overwrite it with whatever STUN servers they trust OR, preferably, specify the proxy addresses manually.
near-bulldozer Bot
pushed a commit
that referenced
this pull request
May 8, 2023
[Audits](https://github.com/near/near-sdk-rs/actions/runs/4690517670/jobs/8376852068?pr=1010) in `near-sdk` highlight a security vulnerability [RUSTSEC-2023-0001](https://rustsec.org/advisories/RUSTSEC-2023-0001) that affects the Windows platform. As far as I could tell, we're not directly impacted by this, but the severity suggests we make an upstream dep update. #8309 (comment) pinned `tokio` to `1.18` and suggested not updating the minor version unconsciously. Whereas #8472 required a bump to `1.19`, which has no versions that patch this vulnerability. This PR seizes the opportunity to re-pin the minor version to the latest, after which subsequent updates can uphold the bump requirement outlined in #8309.
nikurt
pushed a commit
that referenced
this pull request
May 10, 2023
[Audits](https://github.com/near/near-sdk-rs/actions/runs/4690517670/jobs/8376852068?pr=1010) in `near-sdk` highlight a security vulnerability [RUSTSEC-2023-0001](https://rustsec.org/advisories/RUSTSEC-2023-0001) that affects the Windows platform. As far as I could tell, we're not directly impacted by this, but the severity suggests we make an upstream dep update. #8309 (comment) pinned `tokio` to `1.18` and suggested not updating the minor version unconsciously. Whereas #8472 required a bump to `1.19`, which has no versions that patch this vulnerability. This PR seizes the opportunity to re-pin the minor version to the latest, after which subsequent updates can uphold the bump requirement outlined in #8309.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If no public_addrs are configured, a validator node will try to query STUN servers to discover its own IP.
By default a list of public STUN servers provided by Google is used, bu the user is recommended to overwrite it with whatever STUN servers they trust OR, preferably, specify the proxy addresses manually.