Skip to content

fix(browser-detector): set user_agent.original resource attribute always - #6754

Merged
david-luna merged 3 commits into
open-telemetry:mainfrom
david-luna:browser-ua
May 22, 2026
Merged

fix(browser-detector): set user_agent.original resource attribute always#6754
david-luna merged 3 commits into
open-telemetry:mainfrom
david-luna:browser-ua

Conversation

@david-luna

Copy link
Copy Markdown
Contributor

Which problem is this PR solving?

As a result of the discussion in the Browser SIG it is decided that the user agent should be set in the resource. This PR
aligns with the changes proposed in semantic conventions in open-telemetry/semantic-conventions#3738

Short description of the changes

  • set the user_agent.original resource attribute always

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been updated

@david-luna
david-luna requested review from a team as code owners May 22, 2026 10:07
@codecov

codecov Bot commented May 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.95%. Comparing base (6496dbb) to head (c448639).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6754      +/-   ##
==========================================
- Coverage   94.95%   94.95%   -0.01%     
==========================================
  Files         377      377              
  Lines       12744    12743       -1     
  Branches     2897     2896       -1     
==========================================
- Hits        12101    12100       -1     
  Misses        643      643              
Files with missing lines Coverage Δ
...ntelemetry-browser-detector/src/BrowserDetector.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@overbalance overbalance changed the title fix(browser-detector): set user_aget.original resource attribute always fix(browser-detector): set user_agent.original resource attribute always May 22, 2026
@david-luna
david-luna added this pull request to the merge queue May 22, 2026
Merged via the queue into open-telemetry:main with commit 0701e8e May 22, 2026
31 checks passed
@david-luna
david-luna deleted the browser-ua branch May 22, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants