fix(browser-detector): set user_agent.original resource attribute always - #6754
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6754 +/- ##
==========================================
- Coverage 94.95% 94.95% -0.01%
==========================================
Files 377 377
Lines 12744 12743 -1
Branches 2897 2896 -1
==========================================
- Hits 12101 12100 -1
Misses 643 643
🚀 New features to boost your workflow:
|
overbalance
approved these changes
May 22, 2026
user_aget.original resource attribute alwaysuser_agent.original resource attribute always
martinkuba
approved these changes
May 22, 2026
trentm
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
As a result of the discussion in the Browser SIG it is decided that the user agent should be set in the resource. This PR
aligns with the changes proposed in semantic conventions in open-telemetry/semantic-conventions#3738
Short description of the changes
user_agent.originalresource attribute alwaysType of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: