Skip to content

Reuse route-aware clients for OpenAI file uploads - #35717

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/01842415cad2d349a6bd3869abb3332e8110ebce
Jul 28, 2026
Merged

Reuse route-aware clients for OpenAI file uploads#35717
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/01842415cad2d349a6bd3869abb3332e8110ebce

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 28, 2026

Copy link
Copy Markdown

Reuse route-aware clients for OpenAI file uploads

What changed

  • Store a request-logging-disabled RouteAwareClientPool in session services and use it for file creation, blob upload, and finalization requests.
  • Preserve the existing system-root fallback for transport-default proxy routes, and emit a warning event when that fallback is used.
  • Remove the direct reqwest dependency from codex-api now that uploads use the shared HTTP abstraction.

Testing

  • Add coverage for completing multiple uploads through a shared client pool.

## What changed

- Store a request-logging-disabled `RouteAwareClientPool` in session services and use it for file creation, blob upload, and finalization requests.
- Preserve the existing system-root fallback for transport-default proxy routes, and emit a warning event when that fallback is used.
- Remove the direct `reqwest` dependency from `codex-api` now that uploads use the shared HTTP abstraction.

## Testing

- Add coverage for completing multiple uploads through a shared client pool.

GitOrigin-RevId: 01842415cad2d349a6bd3869abb3332e8110ebce
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/01842415cad2d349a6bd3869abb3332e8110ebce branch from e828267 to 899539c Compare July 28, 2026 04:55
@copyberry
copyberry Bot merged commit 899539c into main Jul 28, 2026
14 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/01842415cad2d349a6bd3869abb3332e8110ebce branch July 28, 2026 04:56
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants