NO-JIRA: Hermeto: go mod vendor#17
Merged
openshift-merge-bot[bot] merged 3 commits intoopenshift:mainfrom Apr 22, 2025
Merged
Conversation
https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=67393988 https://download-01.beak-001.prod.iad2.dc.redhat.com/brewroot/work/tasks/3988/67393988/remote-sources.log ``` 2025-04-22 09:02:11,555 INFO Vendoring the gomod dependencies 2025-04-22 09:02:22,047 ERROR vendor/modules.txt changed after vendoring: diff --git a/vendor/modules.txt b/vendor/modules.txt index c6c9b64..974648e 100644 --- a/vendor/modules.txt +++ b/vendor/modules.txt @@ -186,7 +186,6 @@ github.com/prometheus/procfs/internal/fs github.com/prometheus/procfs/internal/util # github.com/robfig/cron/v3 v3.0.1 ## explicit; go 1.12 -github.com/robfig/cron/v3 # github.com/sirupsen/logrus v1.9.3 ## explicit; go 1.13 github.com/sirupsen/logrus 2025-04-22 09:02:23,690 ERROR PackageRejected: The content of the vendor directory is not consistent with go.mod. Please check the logs for more details. Error: PackageRejected: The content of the vendor directory is not consistent with go.mod. Please check the logs for more details. Please try running `go mod vendor` and committing the changes. Note that you may need to `git add --force` ignored files in the vendor/ dir. Docs: https://github.com/hermetoproject/hermeto/blob/main/docs/gomod.md#vendoring 2025/04/22 09:02:24 Skipping step because a previous step failed ```
|
@rayfordj: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
Author
Contributor
Author
|
/label tide/merge-method-squash |
|
@rayfordj: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
|
/approve |
jparrill
approved these changes
Apr 22, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jparrill, kaovilai, rayfordj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=67393988
https://download-01.beak-001.prod.iad2.dc.redhat.com/brewroot/work/tasks/3988/67393988/remote-sources.log