Skip to content

NO-JIRA: go mod tidy#9

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
rayfordj:hermeto/go-mod-tidy
Apr 3, 2025
Merged

NO-JIRA: go mod tidy#9
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
rayfordj:hermeto/go-mod-tidy

Conversation

@rayfordj
Copy link
Copy Markdown
Contributor

@rayfordj rayfordj commented Apr 3, 2025

Update go.mod to support switch from Cachito to Hermeto (Cachi2).

Replacing Cachito with Hermeto (formerly known as Cachi2)

While switching should "Just Work" ™️ , it is not always seemless and we've discovered a discrepancy using Hermeto to deliver sources to fail because an attempt is made to download files during hermetic build.

Update go.mod to support switch from Cachito to Hermeto (Cachi2).

[Replacing Cachito with Hermeto (formerly known as Cachi2)](https://spaces.redhat.com/pages/viewpage.action?pageId=591269742)

While switching should "Just Work" ™️ , it is not always seemless and
we've discovered a discrepancy using Hermeto to deliver sources to fail
because an attempt is made to download files during hermetic build.

 - [Failed scratch build](https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=67227220) without change
 - [Successful scratch build](https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=67229274) with change

Signed-off-by: Rayford Johnson <rayfordj@users.noreply.github.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 3, 2025
@openshift-ci-robot
Copy link
Copy Markdown

@rayfordj: This pull request explicitly references no jira issue.

Details

In response to this:

Update go.mod to support switch from Cachito to Hermeto (Cachi2).

Replacing Cachito with Hermeto (formerly known as Cachi2)

While switching should "Just Work" ™️ , it is not always seemless and we've discovered a discrepancy using Hermeto to deliver sources to fail because an attempt is made to download files during hermetic build.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from csrwng and devguyio April 3, 2025 22:27
@rayfordj
Copy link
Copy Markdown
Contributor Author

rayfordj commented Apr 3, 2025

/assign @jparrill

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 3, 2025

@rayfordj: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jparrill
Copy link
Copy Markdown
Contributor

jparrill commented Apr 3, 2025

/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill, rayfordj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2025
@jparrill
Copy link
Copy Markdown
Contributor

jparrill commented Apr 3, 2025

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit 96f1557 into openshift:main Apr 3, 2025
3 checks passed
@rayfordj rayfordj deleted the hermeto/go-mod-tidy branch April 3, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants