Skip to content

test: optimize the test for TopN in index lookup pushdown.#64867

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
lcwangchao:idx_lookup_pushdown_test
Dec 8, 2025
Merged

test: optimize the test for TopN in index lookup pushdown.#64867
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
lcwangchao:idx_lookup_pushdown_test

Conversation

@lcwangchao
Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: close #64866

What changed and how does it work?

Add some tests for issue #64866 . However this bug is introduced by TiKV, we should wait TiKV to fix this issue

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 5, 2025
@lcwangchao lcwangchao added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 5, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.6981%. Comparing base (00d697f) to head (04ec4b7).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #64867        +/-   ##
================================================
- Coverage   74.6711%   73.6981%   -0.9731%     
================================================
  Files          1891       1870        -21     
  Lines        515863     509535      -6328     
================================================
- Hits         385201     375518      -9683     
- Misses       106806     111909      +5103     
+ Partials      23856      22108      -1748     
Flag Coverage Δ
integration 41.8836% <ø> (-6.2800%) ⬇️
unit 72.8876% <ø> (+0.6313%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 46.4611% <ø> (-16.2099%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lcwangchao lcwangchao force-pushed the idx_lookup_pushdown_test branch from 7347730 to 04ec4b7 Compare December 5, 2025 05:17
@lcwangchao lcwangchao mentioned this pull request Dec 6, 2025
20 tasks
@lcwangchao
Copy link
Copy Markdown
Collaborator Author

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 8, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Dec 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, you06

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 8, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Dec 8, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-08 06:47:34.600607921 +0000 UTC m=+850799.414385483: ☑️ agreed by cfzjywxk.
  • 2025-12-08 06:49:17.347827072 +0000 UTC m=+850902.161604634: ☑️ agreed by you06.

@ti-chi-bot ti-chi-bot bot merged commit 5d1f8dd into pingcap:master Dec 8, 2025
29 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 8, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #64907.
But this PR has conflicts, please resolve them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

the index lookup push down returns wrong value

4 participants