Update vault dependency for v1.2.1 release

[nullpointer0x00]

Description

Bumps github.com/provlabs/vault to v1.2.1 (from v1.1.0) and wires in the changes that came with it. Since the last vault bump in provenance was v1.1.0, this PR picks up both the v1.2.0 and v1.2.1 releases; the release notes for both are included below. In app/app.go, vaultkeeper.NewKeeper now takes the exchange keeper and an exchange query server, which the vault module uses to settle and list exchange payments targeting a vault. In app/upgrades.go, the MigrateVaultAccountPaymentDenomDefaults calls were removed because that method was replaced upstream by a registered Migrate1to2 (ConsensusVersion 1 -> 2) that will run via runModuleMigrations in the next upgrade handler after edelweiss. The vault protos under third_party/proto were synced from the release, swagger was regenerated, and the four new vault queries (VaultNavs, NavValue, VaultPayment, VaultPayments) were added to the provwasm stargate whitelist.

Vault v1.2.1 Release Notes

This is a fast-follow patch release to v1.2.0 containing two minor fixes: a genesis fix so a DefaultAumFeeBips of zero survives export and import instead of being replaced with the module default, and removal of an unused import from tx.proto that tripped downstream IMPORT_USED lint checks.

No state migrations are required.

Improvements

• Removed the unused provlabs/vault/v1/vault.proto import from tx.proto so downstream consumers linting with IMPORT_USED no longer report it #252.

Bug Fixes

• Honor a genesis DefaultAumFeeBips of zero in InitGenesis instead of silently replacing it with the module default, so params round-trip through genesis export and import #253.

Full Commit History

• ProvLabs/vault@v1.2.0...v1.2.1

Vault v1.2.0 Release Notes

This release introduces the internal NAV system and the peer-to-peer multi-asset
vault workflow, allowing a vault to accept external assets in exchange for its
underlying asset through x/exchange settlement, priced against a per-vault NAV
table managed by a designated NAV authority.

It also removes the mixed-denom (payment denom) vault functionality in favor of
the p2p workflow: vaults are now strictly single-denom on their underlying asset,
with a v1 to v2 migration that flattens existing mixed-denom vaults in place.
Vault share markers now require deposit access, restricting principal deposits to
the vault itself.

Features

• Added an internal NAV system: a per-vault, per-denom NAV table with a designated NAV authority, UpdateVaultNAV and UpdateNAVAuthority transactions, VaultNavs and NavValue queries, genesis import/export, and EventNAVUpdated/EventNAVAuthorityUpdated events #189.
• Added a peer-to-peer multi-asset vault workflow that lets a vault take in external assets in exchange for its payment denom: new AcceptAsset and RejectAsset transactions settle or decline pending x/exchange payments targeting the vault, with supporting queries and simulations. Either the vault admin or asset manager may authorize a settlement. Built on the newly integrated Provenance x/exchange module (with its x/hold and x/metadata dependencies) #192.
• Added settlement-time responsibilities to the p2p multi-asset workflow: AcceptAsset now enforces an exact-price guardrail against the vault's internal NAV, records the settlement price in the internal NAV table (removing the entry with a new EventNAVRemoved when an outbound settlement drains the denom), publishes the updated NAV to the marker module attributed to the vault, and triggers a vault reconcile before settling. UpdateVaultNAV likewise reconciles first and publishes the updated NAV to the marker module #193.
• Add a force flag to PauseVault that pauses a vault best-effort when the pre-pause reconcile, valuation, or account persistence fails, falling back to an unvalidated write and recording every tolerated error on EventVaultPaused.forced_error; without it the pause stays strict and aborts on failure #228.

Improvements

• Classify swap-out refund reasons with typed errors instead of fragile error-string matching #90.
• Add simulation tests to validate swap estimation accuracy #112.
• Aligned AutoCLI positional argument order with proto definitions for CreateVault (`#135.
• Switched the valuation engine to read prices exclusively from the per-vault Internal NAV table; UnitPriceFraction now performs a single GetVaultNAV lookup, no longer consults MarkerKeeper.GetNetAssetValue, no longer applies the temporary uylds.fcc 1:1 peg, and surfaces a distinct no internal NAV entry for denom error when an entry is missing. MsgCreateVaultRequest now carries an initial_payment_nav field and Keeper.CreateVault seeds the payment-denom NAV in the same cache context; the field is required (and is rejected as a vault-wide invariant) whenever payment_denom is set and differs from underlying_asset, so a vault can never enter an operational state that would silently stall fee collection or payment-denom swap-outs #190.
• Add an absolute interest-rate ceiling and overflow-safe interest calculations PR 205.
• Document and add test coverage for the bridge mint/burn supply-of-record model, where bridge operations never mutate the vault's TotalShares #207.
• Add a net TVV calculation that subtracts the outstanding AUM fee liability from gross vault value, and use it as the valuation basis for share NAV publication, NAV per share, deposit/redeem conversions, and the captured paused balance PR 213.
• Fix the lint workflow and run it against pull requests, upgrade golangci-lint to v2, and resolve the outstanding lint findings PR 214.
• Reworked GetTVV to value the accepted denoms directly and iterate the per-vault Internal NAV table for held assets instead of walking every principal-marker balance, so Total Vault Value cost scales with the number of valued denoms rather than with whatever is parked at the principal marker #223.
• Share NAV publication is now uint64-safe: when a vault's total shares exceed the uint64 marker volume ceiling, the volume is capped at the uint64 maximum and the price is scaled down proportionally (computed via math/big so the intermediate product cannot overflow), so a correct price-per-share is always published instead of being skipped. Supplies that already fit in uint64 publish their exact share count unchanged. When a vault's supply drops to zero, a previously published share NAV is overwritten with a zero price so a stale price is not served for a share denom that no longer has supply #233.
• Disallow vault creation with a payment denom that differs from the underlying asset. The payment denom must now be empty (defaulting to the underlying) or equal to it. This creation-time check does not itself alter existing vaults; a separate state-machine-breaking migration flattens pre-existing mixed-denom vaults #239.
• Split the expected ExchangeKeeper interface into a keeper part and a new ExchangeQueryServer dependency so consuming apps can wire the exchange keeper and exchangekeeper.NewQueryServer directly instead of writing an adapter struct #247.

Bug Fixes

• Guard NAV valuation multiplications with SafeMul so an oversized net asset value returns an error instead of panicking the block hook #206.
• Enforce per-block visit budgets on all ABCI queue processors (interest timeouts, fee timeouts, payout verification set, and pending swap-outs) and dequeue/refund pending swap-outs for paused vaults so they cannot camp at the front of the queue #225.
• Preserve a pending swap-out and its escrowed shares when a payout or refund fails critically, removing the queue entry only when its payout or refund commits #226.
• Reject swap-in deposits that are too small to mint at least one share, so no funds move when the computed share amount is zero #237.

Deprecated

• Remove the mixed-denom request fields (payment_denom and initial_payment_nav on MsgCreateVaultRequest, redeem_denom on MsgSwapOutRequest and QueryEstimateSwapOutRequest) with their field numbers reserved, while VaultAccount.payment_denom and PendingSwapOut.redeem_denom remain deprecated on the wire for migration decoding #240.

State Machine Breaking

• Remove the mixed-denom (payment denom) vault functionality in favor of the p2p workflow, making vaults strictly single-denom on their underlying asset, with a v1->v2 migration that flattens existing mixed-denom vaults in place #240.
• Enable require_deposit_access on every vault share marker, at creation and via the 1->2 migration for existing vaults, and grant the vault address deposit access so only the vault can move coins into its principal marker #248.

Full Commit History

• ProvLabs/vault@v1.1.0...v1.2.0

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md).
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/).
• Added relevant godoc comments.
• Added relevant changelog entries under .changelog/unreleased (see Adding Changes).
• Re-reviewed Files changed in the Github PR explorer.
• Review Codecov Report in the comment section below once CI passes.

Summary by CodeRabbit

• New Features
  • Added APIs to view vault NAV records and payment details.
  • Added transactions for updating NAV values, changing NAV authority, and accepting or rejecting settled assets.
  • Added NAV and asset settlement events for improved tracking.
  • Added governance support for updating marker require_deposit_access.
  • Added optional forced vault pauses when valuation or reconciliation encounters issues.
• Improvements
  • Clarified single-underlying-asset behavior; legacy denomination fields are now deprecated but retained for compatibility.
  • Added NAV data to vault state export and import.

[coderabbitai]

📝 Walkthrough

Walkthrough

Vault protobuf contracts now support internal NAV records, NAV and payment queries, asset settlement, authority rotation, forced pauses, and new events. Application wiring, query whitelisting, Swagger documentation, marker documentation, and vault/tooling dependencies are updated.

Changes

Vault API and integration update

Layer / File(s)	Summary
Vault data and event contracts third_party/proto/provlabs/vault/v1/{vault,genesis,events}.proto	Vault account semantics, NAV records, genesis state, pause metadata, and NAV/asset settlement events are added or revised.
Vault query and transaction contracts third_party/proto/provlabs/vault/v1/{query,tx}.proto	NAV and payment query endpoints, NAV and settlement transactions, authority rotation, forced pauses, and deprecated denomination fields are defined.
Application wiring and documented API surface app/app.go, internal/provwasm/stargate_whitelist.go, client/docs/swagger-ui/swagger.yaml	Exchange dependencies are passed to the vault keeper, new queries are whitelisted, and the Swagger API reflects the updated contracts.
Marker deposit-access documentation docs/proto-docs.md	Marker deposit-access fields and the governance update transaction are documented.
Vault dependency metadata go.mod, .changelog/unreleased/dependencies/2779-vault.md	The vault module and indirect tooling dependencies are updated with corresponding changelog entries.

Estimated code review effort: 4 (Complex) | ~60 minutes

Possibly related PRs

• provenance-io/provenance#2458: Earlier vault module wiring in app/app.go.
• provenance-io/provenance#2749: Overlapping VaultKeeper constructor wiring in app/app.go.

Suggested reviewers: spicylemon

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely summarizes the main change: updating the vault dependency for the v1.2.1 release.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.57%. Comparing base (a70ac0c) to head (493ab48).
⚠️ Report is 590 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2779      +/-   ##
==========================================
- Coverage   74.50%   70.57%   -3.94%     
==========================================
  Files         318      406      +88     
  Lines       46237    42083    -4154     
==========================================
- Hits        34449    29699    -4750     
- Misses      10381    10634     +253     
- Partials     1407     1750     +343     

Files with missing lines	Coverage Δ
app/app.go	80.19% <100.00%> (-5.49%)	⬇️
internal/provwasm/stargate_whitelist.go	95.98% <100.00%> (ø)

... and 449 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.