Skip to content

fix: ensure USERPASS_FILE credentials store password (set private_type) #20553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smcintyre-r7 merged 1 commit into from
Sep 18, 2025
Merged

fix: ensure USERPASS_FILE credentials store password (set private_type) #20553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/metasploit/framework/credential_collection.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ def each_unfiltered_password_first
end

each_user_pass_from_userpass_file do |user, pass|
yield Metasploit::Framework::Credential.new(public: user, private: pass, realm: realm)
yield Metasploit::Framework::Credential.new(public: user, private: pass, realm: realm, private_type: private_type(pass))
end

additional_privates.each do |add_private|
Expand Down Expand Up @@ -374,7 +374,7 @@ def each_unfiltered_username_first
end

each_user_pass_from_userpass_file do |user, pass|
yield Metasploit::Framework::Credential.new(public: user, private: pass, realm: realm)
yield Metasploit::Framework::Credential.new(public: user, private: pass, realm: realm, private_type: private_type(pass))
end

additional_publics.each do |add_public|
Expand Down