webnn: add 24 tests of integer data types to improve code coverage#59057
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Apr 9, 2026
Merged
webnn: add 24 tests of integer data types to improve code coverage#59057chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
This CL adds 24 new integer data type tests across 16 files to cover previously uncovered code paths in services/webnn/tflite/graph_builder_tflite.cc. Details of the added tests are shown in the following table. |Modified Test File |Tests Added|Types Added | |------------------------|-----------|-------------------------------| |pad.https.any.js |3 tests |int32 (default + value), uint8 | |add.https.any.js |1 test |int32 | |mul.https.any.js |2 tests |int32, uint32 | |div.https.any.js |1 test |int32 | |min.https.any.js |2 tests |int32, uint8 | |max.https.any.js |2 tests |int32, uint8 | |concat.https.any.js |2 test |int32 | |where.https.any.js |1 test |int32 values | |expand.https.any.js |1 test |int32 | |slice.https.any.js |1 test |int32 | |transpose.https.any.js |1 test |int32 | |equal.https.any.js |1 test |int32 inputs | |greater.https.any.js |1 test |int32 inputs | |lesser.https.any.js |1 test |int32 inputs | |reduce_sum.https.any.js |2 tests |int32 (default + axes/keepDims)| |triangular.https.any.js |2 tests |int32 (upper + lower) | Bug: 491318549 Change-Id: I0bbabfa340d0708e9af7d20929c9fad83afa992d Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7698254 Reviewed-by: Hu, Ningxin <ningxin.hu@intel.com> Auto-Submit: Dai, Feng <feng.dai@intel.com> Commit-Queue: Dai, Feng <feng.dai@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/main@{#1611940}
074be5d to
7443592
Compare
wpt-pr-bot
approved these changes
Apr 9, 2026
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL adds 24 new integer data type tests across 16 files to cover
previously uncovered code paths in
services/webnn/tflite/graph_builder_tflite.cc.
Details of the added tests are shown in the following table.
Bug: 491318549
Change-Id: I0bbabfa340d0708e9af7d20929c9fad83afa992d
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7698254
Reviewed-by: Hu, Ningxin <ningxin.hu@intel.com>
Auto-Submit: Dai, Feng <feng.dai@intel.com>
Commit-Queue: Dai, Feng <feng.dai@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1611940}