fix: Add Cmd Default/Input support to cleanup - #183
Conversation
mpdude
left a comment
There was a problem hiding this comment.
Makes sense!
Could you please update dist/cleanup.js as well by running npm run build?
Thanks for the gentle reminder @mpdude. Updated via docker using: Please advise if the update looks incorrect or if you'd like me to use a different version of node or run a modified command. |
|
@mpdude Is there anything else blocking this? |
|
I'd love to see this PR released. I've got self-hosted runners with tons of ssh-agent processes hanging around. This fixes it nicely. |
|
Gentle bump on this PR being merged. This would really help with the cleanup of the |
19c9e1b to
6c290a5
Compare
|
@mpdude, I've rebased my branch from upstream and re-run/updated the Like others above, I'd love to get this into a release. |
|
Also would love to see this one in for our self hosted runners. |
|
Hi guys, I would love to see this one merged also 🙏 🙏 |
|
pls merge this pr @mpdude |
Bring
postaction step into consistency withmainfor changes introduced in #154.Without this change,
sshAgentCmdis undefined when passed toexecFileSync()duringcleanupandpostis never successful.Post job cleanup consistently showing:
Also add entries to the CHANGELOG, detailing v0.8.0 and v0.9.0 releases.
Fixes: #208
Fixes: #211