cache-image input to enable/disable caching of binfmt image

[crazy-max]

follow-up docker/actions-toolkit#200
related to #110
fixes #166

Tested through ci workflow

first run

setup-qemu-action saves image to hosted tool cache: https://github.com/docker/setup-qemu-action/actions/runs/9775565828/job/26986231861#step:3:113

And post cache to upload to GitHub Cache store: https://github.com/docker/setup-qemu-action/actions/runs/9775565828/job/26986231861#step:7:3

second run

download image from cache and load it: https://github.com/docker/setup-qemu-action/actions/runs/9775565828/job/26986391188#step:3:105

---

See cache entries as well: https://github.com/docker/setup-qemu-action/actions/caches

[tonistiigi]

How does this cache get invalidated?

[crazy-max]

How does this cache get invalidated?

when image is downloaded from cache it first loads it to docker store: https://github.com/docker/setup-qemu-action/actions/runs/9775565828/job/26986391188#step:3:110

and to make sure it's up to date we are doing a new docker pull: https://github.com/docker/setup-qemu-action/actions/runs/9775565828/job/26986391188#step:3:113

if image is up to date then we got https://github.com/docker/setup-qemu-action/actions/runs/9775565828/job/26986391188#step:3:116

Status: Image is up to date for tonistiigi/binfmt:master

Otherwise hosted tool cache is evicted and new image is saved in place.

More info on actions-toolkit repo: https://github.com/docker/actions-toolkit/blob/c70efab546578fc88fb6528cd28de42705cda4be/src/docker/docker.ts#L108

[alec-drw]

Why is this also storing it in the tool cache? This is not a tool, and this behavior is not consistent with the use of the tool cache, nor used in any other of the docker actions

[darthShadow]

Is there any output key added to skip pushing to the cache if it already exists? All actions seem to be throwing 409 warnings about matching caches.

Failed to save: Failed to CreateCacheEntry: Received non-retryable error: Failed request: (409) Conflict: cache entry with the same key, version, and scope already exists

[crazy-max]

Is there any output key added to skip pushing to the cache if it already exists? All actions seem to be throwing 409 warnings about matching caches.

Failed to save: Failed to CreateCacheEntry: Received non-retryable error: Failed request: (409) Conflict: cache entry with the same key, version, and scope already exists

Yes we should skip in this case I will take a look.

[crazy-max]

Is there any output key added to skip pushing to the cache if it already exists? All actions seem to be throwing 409 warnings about matching caches.

Failed to save: Failed to CreateCacheEntry: Received non-retryable error: Failed request: (409) Conflict: cache entry with the same key, version, and scope already exists

After investigation it seems related to new cache service v2 that has been enabled in Feb, 11: actions/cache#1541

Looking at comment from maintainer it seems to be an issue on their side that will be fixed in few days: actions/cache#1541 (comment)

Looks like they are going to remove this annotation that was not there before:

But since Feb, 11:

Fyi it makes sense to have this message if you're using setup-qemu-action in multiple jobs within the same workflow as all of them will try to save the cache with the same key and scope. This is the same behavior as @actions/cache.

[crazy-max]

Looks like they are going to remove this annotation that was not there before:

Seems it has been fixed in actions/toolkit#1966

Will bring this in our actions-toolkit

[darthShadow]

Thanks, that will fix the warning.

But doesn't the underlying problem still deserve fixing, because it will always try to re-create the cache entry even if it was a cache hit?