Skip to content

Fix compatibility to ruby-3.2 - #861

Merged
eregon merged 2 commits into
ruby:masterfrom
larskanis:ruby-3.2
Jan 18, 2026
Merged

Fix compatibility to ruby-3.2#861
eregon merged 2 commits into
ruby:masterfrom
larskanis:ruby-3.2

Conversation

@larskanis

@larskanis larskanis commented Jan 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

... which is the default ruby version on Github Actions. URI::Generic#to_str was added in ruby-3.3.

That made the windows new version check fails since 2026-01-13.

Also add the new RubyInstaller releases 4.0.1-1 and 3.2.10-1 to make the PR succeed.

eregon
eregon approved these changes Jan 18, 2026
View reviewed changes

@eregon eregon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eregon
eregon merged commit 80740b3 into ruby:master Jan 18, 2026
215 checks passed
eregon
eregon reviewed Jan 18, 2026
View reviewed changes
Comment thread generate-windows-versions.rb
def validate(versions, allowed_urls_regexps)
versions.values.flat_map(&:values).each do |url|
if allowed_urls_regexps.none? { |regexp| regexp.match? url }
if allowed_urls_regexps.none? { |regexp| regexp.match? url.to_s }

@eregon eregon Jan 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we should convert the URI to a String earlier, we don't want to have URI objects in the JSON.
It works currently but might as well have consistent types for this method.
I'll fix it.

@eregon eregon Jan 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#862

@eregon

eregon commented Jan 18, 2026

Copy link
Copy Markdown
Member

which is the default ruby version on Github Actions

The check in this repo CI uses ruby-version: ruby but I see, you mean https://github.com/ruby/ruby-builder/actions/workflows/check-new-windows-versions.yml
We should fix that to use latest release too for consistency.
But actually I'm thinking to move that CI job here, I don't think it makes sense to have it in that repo anymore.

mergify Bot added a commit to robfrank/linklift that referenced this pull request Jan 25, 2026
@mergify