Skip to content

ending default 404 handler with a newline - #972

Merged
jonathanong merged 1 commit into
senchalabs:masterfrom
rlidwka:nl
Dec 6, 2013
Merged

ending default 404 handler with a newline#972
jonathanong merged 1 commit into
senchalabs:masterfrom
rlidwka:nl

Conversation

@rlidwka

@rlidwka rlidwka commented Dec 6, 2013

Copy link
Copy Markdown
Contributor

I suggest to add a newline after a default 404 handler.

It doesn't matter if you're getting this using a browser, but if you request a page in console, weird thing would happen:

alex@server:~/bin$ curl http://localhost:4873/non/existent/page
Cannot GET /non/existent/pagealex@server:~/bin$ 

Not a big issue, I'm just tired of seeing this. :)

@jonathanong

Copy link
Copy Markdown
Contributor

lol ok

jonathanong added a commit that referenced this pull request Dec 6, 2013
ending default 404 handler with a newline
@jonathanong
jonathanong merged commit a181efd into senchalabs:master Dec 6, 2013
@dougwilson

Copy link
Copy Markdown
Contributor

Seems like you could simply do

alex@server:~/bin$ curl http://localhost:4873/non/existent/page; echo
Cannot GET /non/existent/page
alex@server:~/bin$ 

anyway :)

@rlidwka

rlidwka commented Dec 6, 2013

Copy link
Copy Markdown
Contributor Author

Oh wow, that was fast... I guess people are tired of bike sheds.

Yeah, echo helps when you know that an output doesn't have a newline. But if it already messed with your output, it's too late. :)

@dougwilson

Copy link
Copy Markdown
Contributor

@rlidwka I was just giving a tip as well :) I agree with the acceptance of this merge, because there is no real argument against adding the trailing new line anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants