reikiman
Forum Replies Created
-
I take it this is a site-wide attribute to set on all outgoing links irregardless of the destination domain? Ditto with rel=noreferrer would be site-wide on all outgoing links?
Hm, I found some documentation – so it has to do with security especially blocking certain cross-site-whatever-attacks … hmm…
I’ve never heard of that attribute, and no the plugin does not add that attribute. It could – it’s just a matter of a little bit of code to support another attribute.
Do you have a link to documentation?
I have the target=_blank setting on my site, and it works correctly as you can see here: https://longtailpipe.com/2017/06/19/range-confidence-trumps-range-anxiety-gasoline-users-can-be-anxious-too/
I have no idea how woocommerce works. Is that what you’re using?
This plugin works via filters. Is it possible woocommerce doesn’t trigger the filters?
Forum: Plugins
In reply to: [External & Affiliate Links Processor] Charset changing since last update?I checked more carefully how to handle this.
The code now inserts a <meta> tag as it had done previously to declare UTF8 to the DOM library. At the end it takes steps to remove the spurious DOCTYPE/HTML/BODY tags that got inserted.
Please try version 1.5.4 and let me know how it goes
Forum: Plugins
In reply to: [External & Affiliate Links Processor] Charset changing since last update?I’m running 1.5.4 on WP 4.8 … I created a page using text copied from the German Wikipedia … and it’s displaying correctly as well as I can determine: https://longtailpipe.com/german-text/
I made sure to include some of the characters that are in your text, and they seem to make it through just fine.
Forum: Plugins
In reply to: [External & Affiliate Links Processor] Charset changing since last update?The reason I asked about the plugin version is that in 1.5.4 it switched from
@$html->loadHTML('<meta http-equiv="content-type" content="text/html; charset=utf-8">' . $content);To
@$html->loadHTML($content);The first is a bit of a hack to force UTF8 interpretation of the text. I removed it because it seemed on someone’s site to cause insertion of unwanted other tags. But with that META tag it forces correct interpretation of the text, and that
loadHTMLis well known to mess up text the way you describe it unless it’s explicitly told to use a specific charset like UTF8Forum: Plugins
In reply to: [External & Affiliate Links Processor] Charset changing since last update?Question — which version of the plugin do you have? 1.5.3? 1.5.4?
Forum: Plugins
In reply to: [External & Affiliate Links Processor] Charset changing since last update?Hurm.. It works fine on my site, but then my site is all in US English and therefore wouldn’t trigger this problem. The code does run the $content through a processor, so perhaps there’s some encoding like utf8 I have to account for.
Forum: Reviews
In reply to: [External & Affiliate Links Processor] Caused AMP errorsI checked in a change to resolve the mixed content warnings. Can you update to version 1.5.3 and let me know if it resolves the behavior you saw?
Forum: Plugins
In reply to: [SEO Ultimate] SSL support for the AddThis widgetSorry – that’s the wrong answer.
Forum: Plugins
In reply to: [SEO Ultimate] SSL support for the AddThis widgetYour response is pretty ridiculous. This is not something which should require any PRO feature – but instead is a simple change in your code. Specifically the problem is here:
sharing-buttons.php: , 'addthis_code' => '<a href="http://addthis.com/bookmark.php?v=250"><img src="http://s7.addthis.com/static/btn/v2/lg-share-en.gif" width="125" height="16" alt="' . __('Bookmark and Share', 'seo-ultimate') . '" /></a><script type="text/javascript" src="http://s7.addthis.com/js/250/addthis_widget.js"></script>'If instead of “http://” you simply had “//” then it would work perfectly in either HTTP or HTTPS conditions. Meaning that line should read:
sharing-buttons.php: , 'addthis_code' => '<a href="//addthis.com/bookmark.php?v=250"><img src="//s7.addthis.com/static/btn/v2/lg-share-en.gif" width="125" height="16" alt="' . __('Bookmark and Share', 'seo-ultimate') . '" /></a><script type="text/javascript" src="//s7.addthis.com/js/250/addthis_widget.js"></script>'- This reply was modified 9 years, 1 month ago by reikiman.
Forum: Reviews
In reply to: [External & Affiliate Links Processor] Caused AMP errorsDo you have a record of what meta-tag that is?
Hurm.. after doing a quick code review, I see some potential for mixed-content warnings since some resources are being retrieved from http:// URL’s. I’ll go ahead and work on those, but I don’t think they’d cause problems with AMP pages.
In order to address the problem it would help to know precisely the validation errors.
Yes, it does the right thing. For the case you say, it’ll add &tag=YOURTAG to Amazon links. It supports all the Amazon variants I could find documentation on. It also does similar work for Linkshare (Rakuten) links. It only adds these tags when you tell it to do so. I’m an honest guy.
The affiliate link processing is done by this library, if you want to review it yourself:
Forum: Plugins
In reply to: [External & Affiliate Links Processor] What links get nofollow?I’ve updated the internal documentation and pushed a new release. There’s a couple conditions to consider.
If no blacklist is given, then the default is all links will get rel=nofollow except those in the whitelist.
If a blacklist is given, then only those domains get rel=nofollow, unless for some reason the domain is in the whitelist