Love this module and this is just a small aesthetic request for UX.

With the paragraph type title/label and optional image being shown, it isn't really necessary for the group label to show as well. For example, on my site there's a small graphic and text for the "Text & Image" paragraph, and it also says "text" underneath that as that's the browser group it's in.

I'm currently hiding this label with CSS, but it would be great if there was just a check/uncheck to display group labels option built in.

Thanks for all the great work!

CommentFileSizeAuthor
#12 interdiff_11-12.txt1.74 KBhlopez
#12 3064852-allow-hiding-browser-12.patch5.92 KBhlopez
#11 interdiff_10-11.txt3.23 KBhlopez
#11 3064852-allow-hiding-browser-11.patch5.77 KBhlopez
#10 3064852-allow-hiding-browser-10.patch4.75 KBhlopez
#8 Screenshot from 2019-11-20 15-18-44.png6.03 KBw01f
#8 Screenshot from 2019-11-20 15-10-44.png5.81 KBw01f
#8 Screenshot from 2019-11-20 14-59-38.png6.52 KBw01f
#6 Allow-hiding- browser-group-label--3064852--6.patch3.08 KBa3hill
#5 Screenshot from 2019-08-07 19-16-18.png43.1 KBw01f
#4 Screen Shot 2019-08-04 at 10.19.37 AM.png143.63 KBa3hill

Comments

W0LF created an issue. See original summary.

nortmas’s picture

nortmas commented

agree, for sure not everyone needs it. I also have to remove it with CSS.

gantal’s picture

gantal commented
Issue tags: +dcco2019

Tagging for DrupalCamp Colorado's contrib day.

a3hill’s picture

a3hill commented
StatusFileSize
new Screen Shot 2019-08-04 at 10.19.37 AM.png143.63 KB

Can you provide more clarification on which group label you would like to be able to toggle? Is the attached screenshot highlighting the one you are referring to?

w01f’s picture

w01f commented
StatusFileSize
new Screenshot from 2019-08-07 19-16-18.png43.1 KB

Sorry for the late reply - I'm referring to the group label being shown on the form display as in the attached screenshot.

a3hill’s picture

a3hill commented
StatusFileSize
new Allow-hiding- browser-group-label--3064852--6.patch3.08 KB

Thanks for the screenshot W0LF!

Added a checkbox to the field widget where this can be controlled.

a3hill’s picture

a3hill commented
Status: Active » Needs review
w01f’s picture

w01f commented
StatusFileSize
new Screenshot from 2019-11-20 14-59-38.png6.52 KB
new Screenshot from 2019-11-20 15-10-44.png5.81 KB
new Screenshot from 2019-11-20 15-18-44.png6.03 KB

Thanks @a3hill! I've tested the patch and it works well to hide the group label.

I have 2 other suggestions/requests though.

1. Even hiding the possibly unnecessary group label, the paragraph type label and fields can also be named similarly - perhaps adding an option to hide the paragraph label (and not the icon)?

2. When using custom paragraph icons, the default width of 16px can smush the icon. Would it be possible to change the css from:

.js .paragraph-type-icon {
    padding-right: 5px;
    height: 16px;
    width: 16px;
    vertical-align: middle;
}

to something like:

.js .paragraph-type-icon {
    padding-right: 5px;
    height: 16px;
    width: auto;
    max-width: 50px;
    vertical-align: middle;
}

I'm including a few screenshots to show:

  • Original pre-patch
  • With the patch hiding the paragraph group label
  • With the change in CSS for the icon
gantal’s picture

gantal commented
Issue tags: +DCCO2020

Re-tagging for DrupalCamp Colorado's upcoming contrib day.

hlopez’s picture

hlopez commented
StatusFileSize
new 3064852-allow-hiding-browser-10.patch4.75 KB

Re-roll, original patch failed to apply on 8.x-1.1.

hlopez’s picture

hlopez commented
StatusFileSize
new 3064852-allow-hiding-browser-11.patch5.77 KB
new interdiff_10-11.txt3.23 KB

Added option and functionality to also hide the group filter.

hlopez’s picture

hlopez commented
StatusFileSize
new 3064852-allow-hiding-browser-12.patch5.92 KB
new interdiff_11-12.txt1.74 KB

Hide filter select instead of completely removing to allow use of search functionality. Better checking of component configuration for show_group_label and show_group_filter.