Skip to content

(bug) pr: PR creation failing for stacked commits #350

@vegerot

Description

@vegerot

This just happened when trying to create #349 .

Steps to reproduce:

  1. Make a commit and submit a new PR with sl pr submit
  2. Make another commit and submit another PR with sl pr submit

Expected: PR #348 is updated and PR #349 is created

Actual:

❯ sl status && sl ssl
  o  9d5a48482  Yesterday at 13:13  quark
  │  remotenames: translate 'push --to remote/foo' to 'push default --to foo'
  │
  o  4dcde3c34  Yesterday at 13:13  quark
╭─╯  remotenames: drop forcecompat support
│
│ @  6639efc6c  11 seconds ago  mchcopl  #349 Unreviewed ✓
│ │  util: show all dirty status indicators
│ │
│ o  de3b1d9f1  Yesterday at 10:24  mchcopl  #348 Unreviewed ✓
├─╯  util: add zsh prompt
│
o  7c501efc8  Yesterday at 08:56  remote/main

❯ sl pr submit
#348 is up-to-date
pushing 1 to ssh://git@github.com/vegerot/sapling.git
warning, updating #349 may not have succeeded: {
 "data": {
  "updatePullRequest": {
   "pullRequest": null
  }
 },
 "errors": [
  {
   "type": "UNPROCESSABLE",
   "path": [
    "updatePullRequest"
   ],
   "locations": [
    {
     "line": 3,
     "column": 3
    }
   ],
   "message": "Proposed base branch 'pr348' was not found"
  }
 ]
}
updated body for https://github.com/facebook/sapling/pull/348
force-pushing 76d448b7e3e4f5d7e3c24abf110a5553093f4c90:refs/heads/sapling-pr-archive-vegerot to ssh://git@github.com/vegerot/sapling.git

❯ sl paths
default = ssh://git@github.com/vegerot/sapling.git
upstream = ssh://git@github.com/facebook/sapling.git

Please let me know what other details you need for reproducing

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions